Register device for tesla telemetry #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribe to tesla commands
|
Is there a way for the frontend to tell whether the config has been sent/accepted? How do they know whether to call this endpoint, I suppose is the question. |
The status endpoint from #311 provides this information. If the virtual token is connected and the endpoint confirms it, they know to call this endpoint |
After they call it once, how do they know to not call it a second time? |
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
elffjs
reviewed
Apr 25, 2024
0xdev22
changed the title
Base automatically changed from
feature/si-2559-add-telemetry-status-to-integration-status-endpoint
to
feature/tesla-telemetry-main
May 1, 2024 03:23
…te-endpoint-to-enable-telemetry-for-an-integration
elffjs
deleted the
feature/si-2558-create-endpoint-to-enable-telemetry-for-an-integration
branch
elffjs
added a commit
that referenced
this pull request
May 1, 2024
* Add Telemetry/Subscribe command to Tesla Commands (#305) * Move vehice command to smartcar and tesla client, add telemetry/subscribe to tesla commands * Fix lint issues * Fix issue from PR review * declare commands as constants and use the values * Feature/si 2557 create endpoint to fetch available commands (#308) * Move vehice command to smartcar and tesla client, add telemetry/subscribe to tesla commands * Fix lint issues * Create endpoint for fetching all commands available to an integration * Compute disabled from capable and enabled commands * Change method, generate swagger and remove omitempty * Add tesla virtual key status to integration status endpoint (#311) * Move vehice command to smartcar and tesla client, add telemetry/subscribe to tesla commands * Fix lint issues * Create endpoint for fetching all commands available to an integration * Create endpoint for fetching all commands available to an integration * Create endpoint for fetching all commands available to an integration * Add tesla virtual token status to integration status endpoint * Add tesla virtual token status to integration status endpoint * Fix failing test * Fix issues from PR review * Fix issues from PR review * Fix issues from PR review * Change name from virtual-token to virtual-key * Register device for tesla telemetry (#315) * Move vehice command to smartcar and tesla client, add telemetry/subscribe to tesla commands * Fix lint issues * Create endpoint for fetching all commands available to an integration * Create endpoint for fetching all commands available to an integration * Create endpoint for fetching all commands available to an integration * Add tesla virtual token status to integration status endpoint * Add tesla virtual token status to integration status endpoint * Fix failing test * Function and endpoint to register device for tesla telemetry * Add open telemetry config to environment * Fix issues from PR review * Fix issues from PR review * Fix issues from PR review * Fix issues from PR review * Fix issues from PR review * Fix issues from PR review * Change name from virtual-token to virtual-key --------- Co-authored-by: Dylan Moreland <[email protected]> * Try to cut down on big import diff * More import formatting * More imports * Machine comment * Multiline string for CA * Remove some Fiber middleware we didn't use * Weird comment formatting * Comment for machine * Swap order of set difference. I feel like this is more normal * Misspelling * More import * More encryption * Another machine comment * Nolint * Get rid of the global integration command list for now * Clean up tests * Kill struct * Regen * More Joins, some variable names * Response wrapper * More unmarshal cleanup * URL join --------- Co-authored-by: Doyin.O <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Impacted Routes
/user/devices/:userDeviceID/integrations/:integrationID/commands/telemetry/subscribeCaveats