Add vehicle to tesla telemetry server with tests #285
Conversation
| } | ||
| for _, v := range fields { | ||
| r.Config.Fields[v] = Interval{ | ||
| IntervalSeconds: 1800, |
There was a problem hiding this comment.
Future thoughts - I see there are a lot of different fields. Should we like register different telemetry servers for different fields with different intervals.. Like getting location every 30 seconds but less varying/important data every 1800s (30m) seems fine. I don't know what the limitations of their API is either.
There was a problem hiding this comment.
Its a good observation. We can use thesame server though and just change the interval for the ones that are more important, of course we will have to determine which ones are more important.
There was a problem hiding this comment.
@JamesReate we can specify a different config on a per-vehicle basis.
| @@ -72,7 +73,7 @@ func (udc *UserDevicesController) deleteDeviceIntegration(ctx context.Context, u | |||
| if err != nil { | |||
| return err | |||
| } | |||
| defer tx.Rollback() //nolint | |||
| defer tx.Rollback() // nolint | |||
There was a problem hiding this comment.
Having no space here is correct. It's a comment for machines.
|
Trying to tell the difference between this and #315 |
Proposed Changes
The PR adds the following:
Impacted Routes
/user/devices/:userDeviceID/integrations/:integrationID [post]Caveats