Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Preview (beta) #75

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Release Preview (beta) #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .changeset/pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
},
"changesets": [
"four-squids-change",
"heavy-experts-wonder",
"orange-walls-run",
"silly-cougars-decide"
"silly-cougars-decide",
"ten-mirrors-repair"
]
}
7 changes: 7 additions & 0 deletions docs-app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# docs-app

## 0.0.1-beta.1

### Patch Changes

- Updated dependencies [[`7c7ff9f`](https://github.com/CrowdStrike/ember-headless-form/commit/7c7ff9f47a24eeddd9ac8f9a4c2643eb5e500582), [`eb52f07`](https://github.com/CrowdStrike/ember-headless-form/commit/eb52f0756ed85b34943737248ee0dc569b5408f1)]:
- [email protected]

## 0.0.1-beta.0

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion docs-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "docs-app",
"version": "0.0.1-beta.0",
"version": "0.0.1-beta.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this try to cut an npm release for the docs app? Looks like the package name is just docs-app, so not sure if we want that or not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, no, it's private, so that shouldn't do anything (otherwise that would be really bad).

I guess it bumps the version internally, because its dependencies have changed also, given that the addon was updated. That's at least how I read its own changelog entry: https://github.com/CrowdStrike/ember-headless-form/pull/75/files#diff-39fb47973af070f15e91dd3a8a0cd60c51d42a5036449f6287bca7a6d49139ea

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay that makes sense. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, i'd add docs-app to here: https://github.com/CrowdStrike/ember-headless-form/blob/main/.changeset/config.json#L17

So that the tool has less to do.

"private": true,
"description": "Small description for docs-app goes here",
"repository": "",
Expand Down
12 changes: 12 additions & 0 deletions packages/ember-headless-form/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# ember-headless-form

## 1.0.0-beta.1

### Patch Changes

- [#77](https://github.com/CrowdStrike/ember-headless-form/pull/77) [`7c7ff9f`](https://github.com/CrowdStrike/ember-headless-form/commit/7c7ff9f47a24eeddd9ac8f9a4c2643eb5e500582) Thanks [@simonihmig](https://github.com/simonihmig)! - Yield `rawErrors` for custom error rendering

Both the form and each field yield a `rawErrors` property that gives access to the raw validation error objects for custom error rendering.

- [#74](https://github.com/CrowdStrike/ember-headless-form/pull/74) [`eb52f07`](https://github.com/CrowdStrike/ember-headless-form/commit/eb52f0756ed85b34943737248ee0dc569b5408f1) Thanks [@simonihmig](https://github.com/simonihmig)! - Use describedby instead of errormessage ARIA attribute

Support for `aria-errormessage` is [very incomplete across screen readers](https://a11ysupport.io/tech/aria/aria-errormessage_attribute), therefore switching to the [better supported](https://a11ysupport.io/tech/aria/aria-describedby_attribute), but less specific `aria-describedby`.

## 1.0.0-beta.0

### Major Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-headless-form/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-headless-form",
"version": "1.0.0-beta.0",
"version": "1.0.0-beta.1",
"description": "The default blueprint for Embroider v2 addons.",
"keywords": [
"ember-addon"
Expand Down