Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Preview (beta) #75

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Release Preview (beta) #75

merged 1 commit into from
Mar 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

main is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on main.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

[email protected]

Patch Changes

[email protected]

Patch Changes

@github-actions github-actions bot force-pushed the changeset-release/main branch from 61501da to 7aae1f3 Compare March 8, 2023 17:11
@@ -1,6 +1,6 @@
{
"name": "docs-app",
"version": "0.0.1-beta.0",
"version": "0.0.1-beta.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this try to cut an npm release for the docs app? Looks like the package name is just docs-app, so not sure if we want that or not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, no, it's private, so that shouldn't do anything (otherwise that would be really bad).

I guess it bumps the version internally, because its dependencies have changed also, given that the addon was updated. That's at least how I read its own changelog entry: https://github.com/CrowdStrike/ember-headless-form/pull/75/files#diff-39fb47973af070f15e91dd3a8a0cd60c51d42a5036449f6287bca7a6d49139ea

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay that makes sense. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, i'd add docs-app to here: https://github.com/CrowdStrike/ember-headless-form/blob/main/.changeset/config.json#L17

So that the tool has less to do.

@simonihmig simonihmig merged commit 56b6a06 into main Mar 9, 2023
@simonihmig simonihmig deleted the changeset-release/main branch March 9, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants