Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensemble generation from DB Object tests #349

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Remove ensemble generation from DB Object tests #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/backends/test_dbmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,6 @@ def test_colocated_db_model_ensemble(fileutils, wlmutils, mlutils):
outputs=outputs2,
)

exp.generate(colo_ensemble, overwrite=True)

# Launch and check successful completion
try:
exp.start(colo_ensemble, block=True)
Expand Down Expand Up @@ -688,8 +686,6 @@ def test_colocated_db_model_ensemble_reordered(fileutils, wlmutils, mlutils):
outputs=outputs2,
)

exp.generate(colo_ensemble, overwrite=True)

# Launch and check successful completion
try:
exp.start(colo_ensemble, block=True)
Expand Down Expand Up @@ -816,4 +812,4 @@ def test_inconsistent_params_db_model():
assert (
ex.value.args[0]
== "Cannot set devices_per_node>1 if CPU is specified under devices"
)
)
6 changes: 1 addition & 5 deletions tests/backends/test_dbscript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,6 @@ def test_colocated_db_script_ensemble(fileutils, wlmutils, mlutils):
# Assert we have added both models to each entity
assert all([len(entity._db_scripts) == 2 for entity in colo_ensemble])

exp.generate(colo_ensemble, overwrite=True)

# Launch and check successful completion
try:
exp.start(colo_ensemble, block=True)
Expand All @@ -386,7 +384,7 @@ def test_colocated_db_script_ensemble_reordered(fileutils, wlmutils, mlutils):
script to the ensemble, then colocating the DB"""

# Set Experiment name
exp_name = "test-colocated-db-script"
exp_name = "test-colocated-db-script-reord"

# Retrieve parameters from testing environment
test_launcher = wlmutils.get_test_launcher()
Expand Down Expand Up @@ -466,8 +464,6 @@ def test_colocated_db_script_ensemble_reordered(fileutils, wlmutils, mlutils):
# Assert we have added both models to each entity
assert all([len(entity._db_scripts) == 2 for entity in colo_ensemble])

exp.generate(colo_ensemble, overwrite=True)

# Launch and check successful completion
try:
exp.start(colo_ensemble, block=True)
Expand Down