Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensemble generation from DB Object tests #349

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

al-rigazzi
Copy link
Collaborator

This PR is a quick bugfix. In the DB Object tests (bot DB scripts and DB models), we are currently calling exp.generate for some ensembles, but that is not needed, as they are automatically generated in the exp path.

While this PR fixes the test output path issue, there remains an issue with the generation of ensembles: the path should be honored. I will put up a different ticket for that issue.

@al-rigazzi al-rigazzi self-assigned this Aug 25, 2023
@al-rigazzi al-rigazzi requested a review from MattToast August 25, 2023 15:27
@al-rigazzi al-rigazzi added area: test Issues related to the test suite area: CI/CD Issues related to continuous integration and deployment bug: minor A minor bug labels Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #349 (d350dd0) into develop (c4bf40c) will decrease coverage by 0.33%.
Report is 4 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #349      +/-   ##
===========================================
- Coverage    87.36%   87.04%   -0.33%     
===========================================
  Files           59       59              
  Lines         3546     3551       +5     
===========================================
- Hits          3098     3091       -7     
- Misses         448      460      +12     

see 5 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for chasing this down, this alone is going to make testing locally MUCH easier!!

@al-rigazzi al-rigazzi merged commit b0b4acb into CrayLabs:develop Aug 25, 2023
@al-rigazzi al-rigazzi deleted the fix-dbobject-tests branch September 8, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment area: test Issues related to the test suite bug: minor A minor bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants