Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke srobject.from_pybind() #358

Merged
merged 5 commits into from
Jun 23, 2023
+3 −15
Merged

Nuke srobject.from_pybind() #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a640d86
Add missing header
billschereriii Jun 22, 2023
6acb47a
Revert
billschereriii Jun 22, 2023
b3741ab
Remove srobject.from_pybind() method
billschereriii Jun 22, 2023
921f25c
Merge branch 'develop' of github.com:CrayLabs/SmartRedis into develop
billschereriii Jun 22, 2023
073889a
Merge
billschereriii Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ To be released at some future point in time

Description

- Remove unneeded method from Python SRObject class
- Fixed a memory leak in the C layer
- Remove debug output in pybind layer
- Update Hiredis version to 1.1.0
Expand All @@ -24,6 +25,7 @@ Description

Detailed Notes

- Remove from_pybind() from Python SRObject class as it's not needed and didn't work properly anyway (PR358_)
- Fixed memory leaked from the C layer when calling get_string_option() (PR357_)
- Remove debug output in pybind layer associated with put_dataset (PR352_)
- Updated to the latest version of Hiredis (1.1.0) (PR351_)
Expand All @@ -46,6 +48,7 @@ users need not import `iso_c_binding` in their own applications (PR340_)
- New pip-install target in Makefile will be a dependency of the lib target going forward so that users don't have to manually pip install SmartRedis in the future (PR330_)
- Added ConfigOptions class and API, which will form the backbone of multiDB support (PR303_)

.. _PR358: https://github.com/CrayLabs/SmartRedis/pull/358
.. _PR357: https://github.com/CrayLabs/SmartRedis/pull/357
.. _PR352: https://github.com/CrayLabs/SmartRedis/pull/352
.. _PR351: https://github.com/CrayLabs/SmartRedis/pull/351
Expand Down
15 changes: 0 additions & 15 deletions src/python/module/smartredis/srobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,6 @@ def __init__(self, context):
else:
self._srobject = context

@staticmethod
def from_pybind(srobject):
"""Initialize a SRObject object from
a PySRObject object
:param srobject: The pybind PySRObject object to use for construction
:type srobject: PySRObject
:return: The newly constructed¸ SRObject from the PySRObject
:rtype: SRObject
"""
typecheck(srobject, "srobject", PySRObject)
new_srobject = SRObject(srobject._name)
new_srobject.set_data(srobject)
return new_srobject

@exception_handler
def get_srobject(self):
"""Return the PySRObject attribute
Expand Down