Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuke srobject.from_pybind() #358

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Nuke srobject.from_pybind() #358

merged 5 commits into from
Jun 23, 2023

Conversation

billschereriii
Copy link
Contributor

No description provided.

@billschereriii billschereriii added area: python Issues related to the Python Client bug: minor A minor bug labels Jun 22, 2023
@billschereriii billschereriii requested a review from MattToast June 22, 2023 21:49
@billschereriii billschereriii self-assigned this Jun 22, 2023
MattToast
MattToast approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@billschereriii billschereriii merged commit fd24155 into CrayLabs:develop Jun 23, 2023
@billschereriii billschereriii deleted the srobj branch June 23, 2023 00:28
ashao pushed a commit to ashao/SmartRedis that referenced this pull request Jul 6, 2023
@billschereriii @ashao
Nuke srobject.from_pybind() (CrayLabs#358)
c8bcc91 
[ committed by @billschereriii ]
[ reviewed by @MattToast  ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattToast MattToast MattToast approved these changes

Assignees

@billschereriii billschereriii

Labels
area: python Issues related to the Python Client bug: minor A minor bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billschereriii @MattToast