Prover: couple of fixes betav1 #377

AlexandreBelling · 2024-12-03T00:32:12Z

This PR implements issue(s) #

Checklist

I wrote new tests for my new core changes.
I have successfully ran tests, style checker and build against my new changes locally.
I have informed the team of any breaking changes if there are any.

codecov-commenter · 2024-12-03T00:39:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.20%. Comparing base (8cf2866) to head (acc4322).

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #377      +/-   ##
============================================
+ Coverage     70.17%   70.20%   +0.02%     
- Complexity     1070     1072       +2     
============================================
  Files           306      306              
  Lines         12337    12322      -15     
  Branches       1179     1178       -1     
============================================
- Hits           8658     8651       -7     
+ Misses         3200     3179      -21     
- Partials        479      492      +13

Flag	Coverage Δ		*Carryforward flag
hardhat	`98.70% <ø> (ø)`
kotlin	`67.89% <ø> (+0.02%)`	⬆️	Carriedforward from c5ea7af

*This pull request uses carry forward flags. Click here to find out more.

see 9 files with indirect coverage changes

…hecks in pi-interconnection

…linea-monorepo into prover/couple-of-fixes-betav1

prover/Makefile

prover/circuits/execution/pi.go

prover/circuits/aggregation/circuit.go

prover/circuits/pi-interconnection/assign.go

prover/config/config_test.go

prover/lib/compressor/blob/blob.go

prover/protocol/wizard/gnark_verifier.go

prover/public-input/aggregation.go

* fix(execution): a few fixes in the wizard verifier * feat(dict): pass the dict path from config * fix: makeBw6Proof returns circuitID instead of -1 * fix(circuitID): make bw6Proof returns the circuitID * fix(config-testing) * feat(config): sepolia-full uses full aggregation * style(naming): renaming the rolling hash fields and documenting the checks in pi-interconnection * feat: flag for target number of constraints * fix refactoring oversight --------- Co-authored-by: Arya Tabaie <[email protected]>

* compute genesis shnarf dynamically * use newest ABI for V6 * remove validate tags and branch * use correct var name for council * Update contracts/deploy/06_deploy_TokenBridge.ts Co-authored-by: Diana Borbe - ConsenSys <[email protected]> Signed-off-by: The Dark Jester <[email protected]> * adjust env var names for consistency * Fix: remove github actions warnings (#394) * fix: remove github actions warnings * fix: bump code ql github action version to v3 (#396) * use latest OZ link (#395) * feat: update local compose file for linea-besu delivery39 and plugins (#397) * fix: update github actions versions (#398) * [Feat] - Exclude *.md files from triggering CI workflow (#370) * did .md exclusion rules for workflow files * test md change * add markdown exclusion to pull_request event in main.yml * modify main.yml to ignore *.md file on pull_request * test if main.yml will ignore yml changes * adjust paths exclusion for *.md * test commit * test commit * alternate way for main.yml to filter out .md * test changes to main.yml * test change to main.yml * add compound dorny/path-filter param * fix duplicate workflow id * removed *.yml test value * adjust pr 370 as per comments 1 + test markdown change * revert *.md test change * clarify main.yml comments * test * test * flip to is-markdown-only * Revert "flip to is-markdown-only" This reverts commit 5496a1b. * trial push down * test * test * test * test * test * test * test * remove *.yml * DO NOT MERGE THIS COMMIT - *.yml for demo purpose * remove *.yml after demo done * rename not-markdown-only to has-changes-other-than-markdown * change to has-code-changes * DO NOT MERGE - *.yml test * Revert "DO NOT MERGE - *.yml test" This reverts commit 807d71b. * add docs to exclusion list, replace image extensions * DO NOT MERGE - test ci * Revert "DO NOT MERGE - test ci" This reverts commit ee8831f. * change to has-changes-requiring-build --------- Co-authored-by: Victorien Gauch <[email protected]> * Introduced spotless checks to gradle scripts. Added publishing logic … (#401) * Introduced spotless checks to gradle scripts. Added publishing logic to all the generic jvm libs. Removed redundant useJUnitPlatform() * Removed more useJUnitPlatform() * feat: update copyShadowJarToLocalBesu in finalized-tag-updater gradle build file * fix: geth traces-node running in start-all local stack --------- Co-authored-by: jonesho <[email protected]> * Fixing spotless plugin application performance issue when applied to gradle.build files (#405) * Feat/272 split sdk and postman (#381) * feat: split postman and sdk * fix: update postman client and sendMessage script * fix: clean the sdk * fix: update sdk dependencies * fix: remove .env.sample file * fix: remove testing helpers from the build * fix: update gas provider in linea sdk and update postman client * fix: update postman dependencies * fix: update postman dockerfile and fix tests imports and types * fix: remove unused code in the sdk + move typechain folder * fix: remove unused code + fix imports in postman * fix: pnpm lock file issue * fix: import issue * fix: case sensitive file issue * fix: update sdk fees options and update exports * fix: remove postman unused code and adjust imports and tests * fix: update contracts abis + clean error parsing * fix: update postman based on new SDk changes * add readme + remove unused interface in postman * fix: rename Base.ts file to BaseError.ts * fix: rename Base.ts file to BaseError.ts in postman * chore: update readme for the postman * fix: rename maxFeePerGas to maxFeePerGasCap * fix: update DefaultGasProvider fees check * fix: default gas provider test issue * fix: update main ci filter * fix: issue in default gas provider * feat: update postman docker image version in local stack (#410) * Remove V5 from e2e + allow multiple runs no deploy (#411) * Prover: couple of fixes betav1 (#377) * fix(execution): a few fixes in the wizard verifier * feat(dict): pass the dict path from config * fix: makeBw6Proof returns circuitID instead of -1 * fix(circuitID): make bw6Proof returns the circuitID * fix(config-testing) * feat(config): sepolia-full uses full aggregation * style(naming): renaming the rolling hash fields and documenting the checks in pi-interconnection * feat: flag for target number of constraints * fix refactoring oversight --------- Co-authored-by: Arya Tabaie <[email protected]> * Revert "Revert: Prover: bump to arithmetization beta-v0.8.0-rc6 (#362) (#371)" (#418) This reverts commit 8be665e. --------- Signed-off-by: The Dark Jester <[email protected]> Co-authored-by: Diana Borbe - ConsenSys <[email protected]> Co-authored-by: Victorien Gauch <[email protected]> Co-authored-by: jonesho <[email protected]> Co-authored-by: kyzooghost <[email protected]> Co-authored-by: Roman Vaseev <[email protected]> Co-authored-by: jonesho <[email protected]> Co-authored-by: AlexandreBelling <[email protected]> Co-authored-by: Arya Tabaie <[email protected]>

AlexandreBelling added 4 commits December 2, 2024 13:49

fix(execution): a few fixes in the wizard verifier

1c09e35

fixes for arya to be ready to run

ccb1e0d

fix: makeBw6Proof returns circuitID instead of -1

df7f430

style: remove trailing printfs

119f84b

AlexandreBelling requested a review from Tabaie December 3, 2024 00:32

AlexandreBelling self-assigned this Dec 3, 2024

AlexandreBelling added the Prover Tag to use for all work impacting the prover label Dec 3, 2024

AlexandreBelling had a problem deploying to docker-build-and-e2e December 3, 2024 00:33 — with GitHub Actions Error

Merge branch 'main' into prover/couple-of-fixes-betav1

f3744ba

Tabaie had a problem deploying to docker-build-and-e2e December 3, 2024 05:18 — with GitHub Actions Error

fix(circuitID): make bw6Proof returns the circuitID

2728ae4

AlexandreBelling had a problem deploying to docker-build-and-e2e December 3, 2024 17:38 — with GitHub Actions Error

AlexandreBelling added 2 commits December 3, 2024 19:08

fix(config-testing)

c583b8f

feat(config): sepolia-full uses full aggregation

e8d1db2

AlexandreBelling had a problem deploying to docker-build-and-e2e December 3, 2024 18:09 — with GitHub Actions Error

AlexandreBelling added 2 commits December 3, 2024 19:59

style(naming): renaming the rolling hash fields and documenting the c…

a243866

…hecks in pi-interconnection

Merge branch 'prover/couple-of-fixes-betav1' of github.com:Consensys/…

32ccd47

…linea-monorepo into prover/couple-of-fixes-betav1

AlexandreBelling had a problem deploying to docker-build-and-e2e December 3, 2024 20:00 — with GitHub Actions Error

AlexandreBelling requested a review from gbotrel December 3, 2024 20:52