Revert: Prover: bump to arithmetization beta-v0.8.0-rc6 (#362) (#371)

* Revert "Prover: bump to arithmetization beta-v0.8.0-rc6 (#362)" This reverts commit 31389b1.
Consensys · Dec 2, 2024 · 8be665e · 8be665e
1 parent 1ad6d3e
commit 8be665e
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 10 deletions.
diff --git a/constraints b/constraints
diff --git a/corset b/corset
diff --git a/prover/Makefile b/prover/Makefile
@@ -46,6 +46,13 @@ corset:
 zkevm/arithmetization/zkevm.bin: corset
 	cd ../constraints && $(CORSET) make zkevm.bin && mv zkevm.bin ../prover/zkevm/arithmetization
 
+##
+## Generate `define.go` based on the latest version of corset and the constraints
+##
+wizard: zkevm/define/define.go
+zkevm/define/define.go: corset
+	cd ../constraints && $(CORSET) make -B define.go && mv define.go ../prover/zkevm/arithmetization/define/define.go
+
 ##
 ## Generate the setup for the execution prover (to be run with S3 access)
 ##

diff --git a/prover/README.md b/prover/README.md
@@ -33,4 +33,4 @@ make setup
 ```
 ./integration/run.sh dev-mode
 ./integration/run.sh full-mode
-```
+```
diff --git a/prover/go.mod b/prover/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/consensys/compress v0.2.5
 	github.com/consensys/gnark v0.11.1-0.20240910135928-e8cb61d0be1d
 	github.com/consensys/gnark-crypto v0.14.1-0.20241007145620-e26bbdf97a4a
-	github.com/consensys/go-corset v0.0.0-20241125005324-5cb0c289c021
+	github.com/consensys/go-corset v0.0.0-20241009181119-b687f2ec84ed
 	github.com/crate-crypto/go-kzg-4844 v1.1.0
 	github.com/dlclark/regexp2 v1.11.2
 	github.com/fxamacker/cbor/v2 v2.7.0

diff --git a/prover/go.sum b/prover/go.sum
@@ -100,8 +100,8 @@ github.com/consensys/gnark v0.11.1-0.20240910135928-e8cb61d0be1d h1:TmNupI1+K5/L
 github.com/consensys/gnark v0.11.1-0.20240910135928-e8cb61d0be1d/go.mod h1:f9CH911SPCrbSZp5z9LYzJ3rZvI7mOUzzf48lCZO/5o=
 github.com/consensys/gnark-crypto v0.14.1-0.20241007145620-e26bbdf97a4a h1:yUHuYq+v1C3maTwnntLYhTDmboq3scSo1PQIl375/sE=
 github.com/consensys/gnark-crypto v0.14.1-0.20241007145620-e26bbdf97a4a/go.mod h1:F/hJyWBcTr1sWeifAKfEN3aVb3G4U5zheEC8IbWQun4=
-github.com/consensys/go-corset v0.0.0-20241125005324-5cb0c289c021 h1:zAPMHjY72pXmjuyb/niQ816pd+B9RAmZoL/W/f5uJSU=
-github.com/consensys/go-corset v0.0.0-20241125005324-5cb0c289c021/go.mod h1:J64guTfpmfXl4Yk2D7lsWdYg0ilP+N8JWPudP7+sZpA=
+github.com/consensys/go-corset v0.0.0-20241009181119-b687f2ec84ed h1:tA+JpjGO3tB2+Q7lsrlDper2L5BcvgS2sNd6DLS2ViM=
+github.com/consensys/go-corset v0.0.0-20241009181119-b687f2ec84ed/go.mod h1:J64guTfpmfXl4Yk2D7lsWdYg0ilP+N8JWPudP7+sZpA=
 github.com/coreos/go-semver v0.3.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk=
 github.com/coreos/go-systemd/v22 v22.3.2/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
 github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=

diff --git a/prover/zkevm/arithmetization/definition.go b/prover/zkevm/arithmetization/definition.go
@@ -176,11 +176,10 @@ func (s *schemaScanner) addConstraintInComp(name string, corsetCS schema.Constra
 
 		s.Comp.InsertLocal(0, ifaces.QueryID(name), wExpr)
 
-	case *constraint.RangeConstraint[*air.ColumnAccess]:
+	case *constraint.RangeConstraint:
 
-		bound := cs.Bound()
 		// #nosec G115 -- this bound will not overflow
-		s.Comp.InsertRange(0, ifaces.QueryID(name), s.compColumnByCorsetID(cs.Target().Column), int(bound.Uint64()))
+		s.Comp.InsertRange(0, ifaces.QueryID(name), s.compColumnByCorsetID(cs.Column()), int(cs.Bound()))
 
 	default:
 

diff --git a/prover/zkevm/arithmetization/zkevm.bin b/prover/zkevm/arithmetization/zkevm.bin
+0 −38		CHANGELOG.md
+1 −1		Cargo.lock
+1 −1		Cargo.toml
+3 −10		src/check.rs
+12 −25		src/column.rs
+8 −22		src/compiler/generator.rs
+0 −2		src/compiler/mod.rs
+0 −3		src/compiler/node.rs
+0 −2		src/compiler/parser/definitions.rs
+0 −2		src/compiler/parser/mod.rs
+0 −19		src/compiler/parser/parser.rs
+12 −32		src/exporters/besu.rs
+9 −11		src/exporters/besu_trace_columns.java
+57 −126		src/import.rs
+8 −47		src/inspect/mod.rs
+0 −10		src/main.rs
+29 −17		src/stdlib.lisp
+1 −1		tests/issue241_a.lisp
+2 −2		tests/issue241_c.lisp
+2 −2		tests/issue241_d.lisp
+1 −1		tests/issue241_e.lisp
+0 −2		tests/len_multiplier_1.accepts
+0 −3		tests/len_multiplier_1.lisp
+0 −2		tests/len_multiplier_1.rejects
+0 −5		tests/len_multiplier_2.lisp
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,4 +33,4 @@ make setup @@
     ```
     ./integration/run.sh dev-mode
     ./integration/run.sh full-mode
-    ```
+    ```