Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling in upstream #16

Merged
merged 11 commits into from
Sep 11, 2020
Merged

Pulling in upstream #16

merged 11 commits into from
Sep 11, 2020

Conversation

chrisgervang
Copy link
Member

No description provided.

chrisgervang and others added 11 commits July 12, 2020 21:30
Pinning node to version 12.6.3 per discussion. Upgrading to deck 8.2.2
…ne (#15)

* Minor keyframe class clean up, removing unused defaults

* Camera and Layers are optional in a DeckScene

- Animating the camera is optional, but if a keyframe is defined then viewState is controlled by camera keyframe.
  - To Use: do not provide a `camera` to `keyframes` parameter when constructing DeckScene.
- Animating layers is optional, only replace layers prop when scene provides layers.
  - To Use: do not provide a `renderLayers` parameter when constructing DeckScene

* Adding Camera Example to docs
…13)

* [FIX/ADD] Fixed missing steps to instructions + added extra notation

* [FIX] Forgot missing step in #8

* [FIX/ADD] Fix step 9 and added clarification

* [DEL] Extraneous folders/files
...so the background doesn't look so empty.
@chrisgervang chrisgervang merged commit f22467f into CodeLabs-Hubble-gl:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants