Lint subspecs #202
Closed
Lint subspecs #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently subspecs are not being linter for their "root" attributes. This includes name, and possibly other attributes. Since the linter will only lint attributes present in a spec anyway, it will not try to lint properties that don't exist. This change makes it so all subspecs are linted for all specs. Additionally, the root spec name is moved into a separate function to ensure it is not called unecessarily. This change is based off of the changes by Samuel Giddins and is in a separate commit to give credit
|
The issue with this is that there will be duplicate warnings/errors for root attributes, no? |
|
@segiddins that is a good point. There is a little more thought to this then, but I feel like it's progress. |
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
The spec is based off of the changes by @segiddins in CocoaPods#178 and @kaplin in CocoaPods#202. So this supersedes and closes CocoaPods#178, CocoaPods#202. This fixes CocoaPods#177.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently subspecs are not being linter for their "root" attributes. This includes name, and possibly other attributes. Since the linter will only lint attributes present in a spec anyway, it will not try to lint properties that don't exist.
This change makes it so all subspecs are linted for all specs. Additionally, the root spec name is moved into a separate function to ensure it is not called unnecessarily.
This change is based off of the changes by @segiddins and is in a separate commit to give credit.
Closes #178 and #177