[LinterSpec] Add spec for subspec names with whitespace #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kapin would appreciate your help on this one |
|
Was playing with it last night. I need to get a good debugger and figure out why it's being dumb. I'd be completely for pulling the linter apart, it's just I don't know why it's not linting subspecs properly. |
|
@kapin it is linting subspecs properly, the issue is that the |
Closed
|
@segiddins see #202. It should cover that issue, although it needs way way more testing imo. |
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
The spec is based off of the changes by @segiddins in CocoaPods#178 and @kaplin in CocoaPods#202. So this supersedes and closes CocoaPods#178, CocoaPods#202. This fixes CocoaPods#177.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #177
@kylef here's the spec, I just can't figure out a way to get the linter to lint the
nameattribute of subspecs without changing too much