Quick fix validation reading entire zarr store for QC check #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @dgergel, for a quick look at this, if you can spare a moment. (thank you) |
dgergel
approved these changes
Nov 4, 2021
This was referenced Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation tries to read entire Zarr stores into memory to perform some checks.
This PR implements the work-around in https://github.com/ClimateImpactLab/downscaleCMIP6/blob/0122ce6730de73c6b64b8e9ca120e2bfaf95e7bb/workflows/templates/qualitycontrol-check-cmip6.yaml#L47 as a quick fix to the problem. Basically reading annual slices through via dask.delayed.