Update Magiclysm's enchanted rings armor layers and add a "SKINTIGHT" flag to vanilla rings. #60088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix Magiclysm obsolete armor layers to match vanilla ones and add a ''SKINTIGHT'' flag to vanilla rings."
Purpose of change
I changed magiclysm's enchanted_rings.json armor layers to better represent the vannila ones.
I also added the
"SKINTIGHT"
flag to all rings in jewelry.json to partially fix conflicts with gloves.This PR may close #60058 but I'm not entirely sure.
Describe the solution
I have added the
"specifically_covers": [ "hand_fingers_l", "hand_fingers_r" ]
line to make it only cover the fingers and not the entire hand. I have also added the missing"SKINTIGHT"
flag to the rings so the majority of the gloves can be worn with rings.Describe alternatives you've considered
Don't add the
"SKINTIGHT"
flag and find a better solution to deal with rings and gloves.As a side note, I'm open to any suggestions and ideas.
Testing
I have tested it, and it's working as intended. The vanilla rings have the flag and it's not comflicting with normal layer gloves anymore.
Magiclysm is also working as intended. I have spawned several enchanted rings and they now only cover the fingers, and it's only possible to wear one per hand.
Below are some screenshots to prove it.
Additional context