Fixes for multi material damage rolls #55607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
json-styled
Maleclypse
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
I spent all that time working on getting the coverage tests to be more reliable... turns out I had made a mistake in the original #55405 and didn't replace both instances of where that code happened... So no locations with sublimbs were calculating differently, which were the primary locations where you get hit... When I made everything have sublimbs in #55498 that made the test go back to failing consistently. This will fix that.
Good test it's currently caught 4 of my own dumb errors...
Describe the solution
added the remaining missing code.
Describe alternatives you've considered
Testing
looks like the difference now works...
Additional context