Materials Roll Individually For Direct Attacks

[bombasticSlacks]

Summary

None

Purpose of change

Materials on armor didn't work exactly how people thought but wanted to use it in PR's like #55316, where the desired outcome is materials may overlap, protect with only 1, or protect with none. Before the material roll was fixed for all materials so if you had two 80% materials you always got both or none, never that middle ground chance.

This fixes that.

Describe the solution

Made it so passing a negative value for roll to the relevant call stack makes it roll a chance per material at the lowest level.

So for UI and such you can still pass a fixed material roll (including 0 for legacy calcs).

Added a unit test for this stuff.

Describe alternatives you've considered

Testing

Added a unit test specifically testing for this. Using a large number of materials to minimize variance.

Additional context

This should effect basically no balance since almost no items are made of 2+ non 100% proportional coverage materials.

[PlutusPleion]

Interesting, I didn't know it only used a single roll to check all materials. I thought it rolled on each material entry.

[bombasticSlacks]

Interesting, I didn't know it only used a single roll to check all materials. I thought it rolled on each material entry.

your PR is why I checked it to make sure 😆