Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainmail standardization #55455

Merged
merged 29 commits into from
Feb 19, 2022
Merged

Conversation

Drew4484
Copy link
Contributor

@Drew4484 Drew4484 commented Feb 17, 2022

Summary

Content "Standardizes application of chainmail, removes chainmail/gambeson combos."

Purpose of change

As more items with chainmail are being updated, the standard of 1.2 mm (18 gauge) thickness will be used. After discussing chainmail, the decision was made to remove the integrated gambeson versions of chainmail armor. This allows greater player flexibility, removes a chainmail (outer) over chainmail gambeson (normal layer) exploit, and also cleans up repairing each item separately rather than using cotton to repair a damaged section of chainmail.

Describe the solution

Changes all standard chainmail to 1.2mm thickness, the same as 18 gauge steel.
Adjusts plate armors integrating chainmail thickness accordingly.
Removes gambesons from all chainmail suits/hauberks.
Obsoletes kevlar chainmail suits/hauberks.
Adds grades of steel to chainmails.

Describe alternatives you've considered

None.

Testing

Loaded items in game, verified changes.

Additional context

As the chainmail armors are having the gambesons removed, this may invalidate some of #55392.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 17, 2022
@anoobindisguise
Copy link
Contributor

1.2 mm may be the actual width of the chains themselves, but is it accurate? The chains are not perfectly flat, there is a somewhat uneven pattern to them that would increase thickness. This is going to give the chainmail a protection of only 6, which is low enough for common zombies to bleed you through full chainmail with claw swipes. and that doesn't seem reasonable considering that chainmail will generally protect you from full sword swipes. All steel armor suffers from a lack of cut protection but this seems particularly below real life.

@Drew4484
Copy link
Contributor Author

1.2 mm may be the actual width of the chains themselves, but is it accurate? The chains are not perfectly flat, there is a somewhat uneven pattern to them that would increase thickness. This is going to give the chainmail a protection of only 6, which is low enough for common zombies to bleed you through full chainmail with claw swipes. and that doesn't seem reasonable considering that chainmail will generally protect you from full sword swipes. All steel armor suffers from a lack of cut protection but this seems particularly below real life.

I want to stick with the lower end of thickness for chain because in cases with layered armor like the plate, it quickly becomes thicker than the actual plate armor. The armors that are only set to use standard steel (chainmail suit, chainmail hauberk, assorted individual pieces) will suffer from this change because they previously had thickness 5-6. I didn't want to make the full grades of steel versions of all of those suits and pieces on this PR but that should to happen eventually.

@Maleclypse Maleclypse added the Items / Item Actions / Item Qualities Items and how they work and interact label Feb 17, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • XL hardened steel chainmail hauberks
  • XL high steel chainmail hauberks
  • XL low steel chainmail hauberks
  • XL medium steel chainmail hauberks
  • XL tempered steel chainmail hauberks
  • XS hardened steel chainmail hauberks
  • XS high steel chainmail hauberks
  • XS low steel chainmail hauberks
  • XS medium steel chainmail hauberks
  • XS tempered steel chainmail hauberks
  • hardened steel chainmail hauberks
  • high steel chainmail hauberks
  • low steel chainmail hauberks
  • medium steel chainmail hauberks
  • tempered steel chainmail hauberks

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Feb 18, 2022
@Drew4484
Copy link
Contributor Author

Drew4484 commented Feb 18, 2022

Went ahead and introduced grades of steel for all chainmail armors (except faraday/faraday shark, dog/horse).

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 18, 2022
@Drew4484 Drew4484 removed the request for review from anothersimulacrum February 18, 2022 06:42
Changes all standard chainmail to 1.2mm thickness, the same as 18 gauge steel.
Adjusts plate armors integrating chainmail thickness accordingly.
Removes gambesons from all chainmail suits/hauberks.
Obsoletes kevlar chainmail suits/hauberks.
Adds steel grades to chainmail.
Obsoletes standard steel chainmail recipes.
Obsoletes gambeson+chainmail recipes.
@Drew4484 Drew4484 force-pushed the Chainmail-Standards branch from 79b9c93 to f1f8761 Compare February 18, 2022 06:58
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Feb 18, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Feb 18, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 18, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 18, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 19, 2022
@Drew4484
Copy link
Contributor Author

What a comically large number of changes. Looks good to me, I like the name shorten for the other steel mats.

Also 3 separate "balance" PRs to the Kevlar hauberks which ended with just removing them is also pretty funny.

probably in a seperate PR it would be worth it to make chain repair with chain links and only a soldering iron? Though I'm not an armorer so 🤷.

Makes sense to repair with links, usually you're only replacing a small number. I'll start that as a separate PR down the line.

@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • XL hardened steel chainmail coifs
  • XL hardened steel chainmail hauberks
  • XL high steel chainmail coifs
  • XL high steel chainmail hauberks
  • XL low steel chainmail hauberks
  • XL medium steel chainmail coifs
  • XL medium steel chainmail hauberks
  • XL mild steel chainmail coifs
  • XL tempered steel chainmail coifs
  • XL tempered steel chainmail hauberks
  • XS hardened steel chainmail coifs
  • XS hardened steel chainmail hauberks
  • XS high steel chainmail coifs
  • XS high steel chainmail hauberks
  • XS low steel chainmail hauberks
  • XS medium steel chainmail coifs
  • XS medium steel chainmail hauberks
  • XS mild steel chainmail coifs
  • XS tempered steel chainmail coifs
  • XS tempered steel chainmail hauberks
  • hardened steel chainmail coifs
  • hardened steel chainmail hauberks
  • high steel chainmail coifs
  • high steel chainmail hauberks
  • low steel chainmail hauberks
  • medium steel chainmail coifs
  • medium steel chainmail hauberks
  • mild steel chainmail coifs
  • tempered steel chainmail coifs
  • tempered steel chainmail hauberks

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 19, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 19, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 19, 2022
@kevingranade kevingranade merged commit 9f25f7c into CleverRaven:master Feb 19, 2022
PlutusPleion added a commit to PlutusPleion/Cataclysm-DDA that referenced this pull request Feb 19, 2022
@Drew4484 Drew4484 deleted the Chainmail-Standards branch June 20, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants