-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and fix kevlar chainmail armor, hauberk, missing recipes, errors and inconsistencies #55392
Update and fix kevlar chainmail armor, hauberk, missing recipes, errors and inconsistencies #55392
Conversation
one of the kevlar_chainmail_suit needed a "id_suffix" because if it doesn't the second one just overwrites the first. realized there's missing XS gambeson hood and XS gambeson pants.
A lot to do still, wanted to make one small change and there's been new bugs found:
Testing:
|
Add gambeson hood to XL recipe. Add XL recipe that can craft with hauberk.
XS kevlar hood did exist, but it was missing "kevlar" in name. Created missing XS version of kevlar gambeson arming pants. Added both XS items to XS full suit recipe.
Overall this looks good, the 100% coverage for the soft layers and the 95% for the chain is in line with other chainmail. It looks like you've got XS components in recipes for normal sized gear. These should be separate and incompatible between XS/normal/XL. The steel thickness should be consistent across the entire body, I've used 1 mm on the plate mail and gloves. I haven't applied new steels to chainmail yet but if you wanted to update these to use the grades you can swap those materials in without worrying about weight or volume. |
Did final check each piece should now only allow similar size for crafting. The exception of allowing normal size to craft for XS as well. I figure resizing normal to xs should be okay. I can remove it if that's not desired. Which grades should be used for chainmail? I'm not too familiar in metallurgy. From a quick look the standard steel has similar properties to medium so should I use that grade? edit: might have some incompatibilities or overlap with #55222 Did some research and made changes you suggested but now it's weaker than normal chainmail. Should I revert the material thickness of the med_steel back to 2.5? or should I be fixing the other chainmail gear for consistency? @Drew4484 edit2: So it's supposed to be between 14 gauge(2mm) and 18 guage(1.2mm). Really unsure which direction to take here. #55224 - Added light activity level for kevlar chainmail and its variants. Fixed the example but not root problem. |
For some reason "copy-from" doesn't copy the activity level so it has to be manually inputted.
I can close #55222 however there are still some recipe inconsistencies in this PR. Edit: Actually it seems the id_suffixes are okay, but the duplicate gambesons are still an issue. |
Removed duplicate and gambeson for normal chainmail armor. |
…d gambeson hood to recipe because stats reflect it
1.2 mm is a good number, we can establish that consistent across all chain armor. Because of the way armoring works, if we go for the upper boundary of 2 mm it will be as effective as solid plate steel. As far as the steel grades, all are suitable as a material. The progression of mild/medium/high/hardened/tempered is effectively linear in terms of protective values and also crafting difficulty. I would recommend using the mild steel for your initial suit, and then we can copy-from variants for the other grades of steel. |
Updated chainmail coif, armor, hauberk, vest, legging and sleeves. All using low_steel and uniform thickness for the steel. |
…as stats of having a gambeson underneath and fix chainmail armor recipe time we are just "joining" already linked chainmail
accidentally closed |
"material": [ | ||
{ "type": "kevlar", "covered_by_mat": 100, "thickness": 1.3 }, | ||
{ "type": "kevlar_layered", "covered_by_mat": 100, "thickness": 1.9 }, | ||
{ "type": "steel", "covered_by_mat": 95, "thickness": 2.5 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The steel thickness should be consistent as the rings would be mass produced to a uniform measure. There are cases where smaller rings are used but that dramatically increases the labor time. Typical thickness was between 1 - 1.5 mm, I've used 1 mm for other chain sections on the plate armor.
closed due to more encompassing changes in #55455 |
Summary
Balance "Update chainmail gear and kevlar-chainmail variants' materials including numerous fixes"
Purpose of change
Kevlar Chainmail Armor is made by combining components of:
It's safe to assume there should be overlap. There are also minor differences like the gambeson and arming pants being 100% coverage while the chainmail gear being 95% coverage.
We have systems in place to allow for complex armor such as this.
Another problem that was found is that the kevlar chainmail armor had stats that would assume it incorporated a kevlar gambeson hood, except it was not part of the recipe.
Describe the solution
Here should be the totals for each bodypart:
head:
95% coverage (1.2 Steel)
100% coverage (1.9 Layered Kevlar, 1.3 Kevlar, 2.5 Cotton*)
torso, arms, legs:
95% coverage (1.2 Steel)
100% coverage (1.9 Layered Kevlar, 1.3 Kevlar, 2.5 Cotton*)
Describe alternatives you've considered
Testing
-Checked each recipe is correct and shows up
-Checked the materials are correct
-Checked resistances and coverage are correct
-No errors on load
Additional context