-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unarmed weapons are wearable and added wrist sub-limbs #54313
Conversation
if something doesn't specify sublocations it is assumed to cover all sublocations on that body part. So if the intent is for there to be two distinct zones "fingers" where you have brass knuckles or whatever and "wrist" where you have a watch. you have to make a fingers sublocation too. |
There's also the fitness band, game watch, radiation monitor and bracelets. |
Relevant: #53822 |
It seems that in the comments of #41209 it was decided not to have the "knuckles" items be wearable as they actually take up space in the palm and therefore prevent other things from being held in the hands. They don't just wrap around the fingers like the cestus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these shouldn't have secondary. Basically no sublimbs should
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
I see where that is coming from but there is no mistake that Brass Knuckles and the like need to be placed on the fingers to be used. You couldn't just hold a pair of Spiked Brass Knuckles in your hand and attack with them the same way as if they were worn. The best idea I can think of as a compromise is to make these weapon have a large amount of hand encumbrance to discourage holding another item. |
But increasing hand encumbrance would also make unarmed attacks worse too, right? |
It would. Definitively sounds like this should be looked in more in-depth since neither choice seems ideal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright so this makes the wrist 10% of the hand, fingers 50%, and adds a palm to round it out covering 40%.
When defining coverage for a place with sublocations you are telling the game how much of the sublocation is covered not how much of the overall location. So for example when a watch is 10 coverage, on the wrist the game thinks its 10% of the wrist (which is 10% of the hand; so 1% overall coverage). So I've adjusted the coverage values to maintain the numbers you already had but in that system where it converts.
data/json/body_parts.json
Outdated
{ | ||
"id": "hand_wrist_r", | ||
"type": "sub_body_part", | ||
"max_coverage": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"max_coverage": 5, | |
"max_coverage": 10, |
data/json/body_parts.json
Outdated
{ | ||
"id": "hand_fingers_r", | ||
"type": "sub_body_part", | ||
"max_coverage": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"max_coverage": 5, | |
"max_coverage": 50, |
data/json/body_parts.json
Outdated
{ | ||
"id": "hand_wrist_l", | ||
"type": "sub_body_part", | ||
"max_coverage": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"max_coverage": 5, | |
"max_coverage": 10, |
data/json/body_parts.json
Outdated
{ | ||
"id": "hand_fingers_l", | ||
"type": "sub_body_part", | ||
"max_coverage": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"max_coverage": 5, | |
"max_coverage": 50, |
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Co-authored-by: Dillon Matchett <[email protected]>
Summary
Balance "Unarmed weapons are wearable and added wrist sub-limbs"
Purpose of change
Fixes #53822
Unarmed weapons are wearable. Added Wrist and Fingers sub-limbs
Describe the solution
This PR is focused on several changes regarding the character's "hand" limb.
Unarmed Weapons are now wearable. Following the example of #41209 all other non-CBM unarmed weapons have been converted to
ARMOR
items that are worn on the hands. These items no longer have theUNARMED_WEAPON
flag meaning they must be worn to add their damage to unarmed attacks. The follow items have been changed:In addition, these items are no longer classified as style weapons for Aikido and Judo. Wearing the above items and attacking without a weapon will still make them contribute unarmed damage as normal. Due to the nature of tiger claws (bagh nakha) and bionic claws, they are still classified as style weapons for Aikido and Judo and retain the
UNARMED_WEAPON
flag.Added wrist sub-limbs.
arm_wrist_r
andarm_wrist_l
have been added to the body parts list as a sub-limbs ofhand_r
andhand_l
respectively. Items that cover the wrist have been updated to state they specifically cover the wrist part of the hand. These items are all watches:Added fingers sub-limbs.
arm_fingers_r
andarm_fingers_l
have been added to the body parts list as a sub-limbs ofhand_r
andhand_l
respectively. The above unarmed weapons and all ring jewelry use this slot.