Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hint .to_json_dict() better #772

Merged
merged 7 commits into from
Oct 25, 2024
Merged

hint .to_json_dict() better #772

merged 7 commits into from
Oct 25, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Oct 25, 2024 •
edited
Loading

Draft For:

  • some types aren't actually producing or expecting dicts

@altendky
Copy link
Contributor Author

i forget every time. this is why we never hint json.

https://github.com/Chia-Network/chia-blockchain/actions/runs/11510910978/job/32043489047?pr=18765

@altendky altendky closed this Oct 25, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11520800885

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.811%
Totals Coverage Status
Change from base Build 11510822843: 0.0%
Covered Lines: 12844
Relevant Lines: 15325
💛 - Coveralls

@altendky altendky reopened this Oct 25, 2024
@altendky altendky mentioned this pull request Oct 25, 2024
Merged
@altendky altendky marked this pull request as ready for review October 25, 2024 15:46
@altendky
Copy link
Contributor Author

new ref usage in chia-blockchain https://github.com/Chia-Network/chia-blockchain/actions/runs/11520755337?pr=18765

@altendky altendky requested a review from Rigidity October 25, 2024 16:04
@altendky altendky merged commit d4a1a53 into main Oct 25, 2024
52 checks passed
@altendky altendky deleted the hint_to_json_dict_better branch October 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@Rigidity Rigidity Awaiting requested review from Rigidity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altendky @arvidn