-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct wallet rpc api for get spendable coins with specified excluded coins #18768
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait sorry, does this work? If excluded_coins_input.values
is dict[str, Any]
then Coin.from_json_dict
isn't going to ever match it right?
It's not tested, I just know the hinting here. chia-blockchain/chia/wallet/signer_protocol.py Lines 18 to 23 in e2c63db
Does the |
This situation was pointed out when I tried the now merged Chia-Network/chia_rs#772 in blockchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm I'm dumb
Purpose:
found while exploring more hinting with Chia-Network/chia_rs#772
note that this is related to the older object field name that we back-compat support on the api end
Current Behavior:
New Behavior:
Testing Notes: