Japanese translation has been completed. #751

kuragehimekurara1 · 2022-04-09T18:35:33Z

Please confirm that the Japanese translation has been completed.

Japanese translation has been completed.

Added Japanese translation of timeline

commit-lint · 2022-04-09T18:35:36Z

Code Refactoring

update login_sign_up_link_target (2cea34d)

Contributors

kuragehimekurara1, Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

Chesire · 2022-04-09T20:59:01Z

Thanks for this!
The translations are currently replacing the English strings, would it be possible to put them in libraries/core/src/main/res/values-ja/strings.xml and can look to get this merged in

kuragehimekurara1 · 2022-04-09T22:00:02Z

Thanks for this!
The translations are currently replacing the English strings, would it be possible to put them in libraries/core/src/main/res/values-ja/strings.xml and can look to get this merged in

Should I create a new file and put strings.xml in it?

Chesire · 2022-04-10T10:05:06Z

If you create the required directories and put the new strings.xml there it should be all good.

The idea is to have the values folder which contains the strings file for English, and a values-ja folder which contains the strings file for Japanese

kuragehimekurara1 · 2022-04-10T10:19:14Z

I understand!　　Do I just create a new pull request when I'm done?

Chesire · 2022-04-10T13:35:30Z

You can update this one (assuming the English strings are put back), or create a new one. Whichever you find easier for you 😃

kuragehimekurara1 · 2022-04-10T13:38:01Z

Yes, sir.

Please confirm that the Japanese translation has been completed.

Corrected the translation of strings.xml

kuragehimekurara1 · 2022-04-10T16:13:13Z

I created a values-ja folder and added the strings.xml file translated into Japanese in it. Also, the original strings.xml file has been restored to English. How about this?

codecov · 2022-04-10T19:17:10Z

Codecov Report

Merging #751 (2cea34d) into master (c82f189) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #751      +/-   ##
============================================
- Coverage     68.98%   68.79%   -0.20%     
+ Complexity      441      436       -5     
============================================
  Files           109      109              
  Lines          1680     1679       -1     
  Branches        143      145       +2     
============================================
- Hits           1159     1155       -4     
  Misses          478      478              
- Partials         43       46       +3

Impacted Files	Coverage Δ
...com/chesire/nekome/core/flags/HomeScreenOptions.kt	`87.50% <0.00%> (-12.50%)`	⬇️
...ain/java/com/chesire/nekome/core/settings/Theme.kt	`88.88% <0.00%> (-11.12%)`	⬇️
.../com/chesire/nekome/core/flags/UserSeriesStatus.kt	`92.30% <0.00%> (-7.70%)`	⬇️
...in/java/com/chesire/nekome/kitsu/user/KitsuUser.kt	`87.50% <0.00%> (ø)`
...e/datasource/auth/remote/AuthRefreshInterceptor.kt	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82f189...2cea34d. Read the comment docs.

Chesire

The changes look good, thanks for this.
One additional change to get this working is to update the app/build.gradle to include

    defaultConfig {
        applicationId "com.chesire.nekome"
        minSdk 21
        targetSdk sdk_version
        versionCode 22040915 // Date of build formatted as 'yyMMddHH'
        versionName "1.5.3"
        testInstrumentationRunner "com.chesire.nekome.TestRunner"
        resConfigs "en", "ja"
    }

as the resConfig is only setup for en currently.

Chesire · 2022-04-10T20:51:46Z

libraries/core/src/main/res/values-ja/strings.xml

+    <string name="login_forgot_password_url">https://kitsu.io/password-reset</string>
+    <string name="login_sign_up">まだKitsuに登録されていませんか？ こちらからKitsuに登録出来ます</string>
+    <!-- This text should be exactly what part of login_sign_up should be a link -->
+    <string name="login_sign_up_link_target">サインアップ</string>


The text in this string will need to be a part of the string above it. In English

<string name="login_sign_up">Not yet registered? Sign up</string>  <string name="login_sign_up_link_target">Sign up</string>

it uses the Sign up part as a link.
Could this be こちらからKitsuに登録出来ます?

How should I change the sign up part?

login_sign_up needs to contain the text from login_sign_up_link_target as it sets up a link using login_sign_up_link_target.
login_sign_up_link_target is not displayed to the user, its just used to lookup which part of the login_sign_up should contain a link.

It should be whichever part of login_sign_up is the equivalent to "Sign up"

Sorry for the late correction.
The translation has been corrected. How about this?

Made a change to what I think it needs to be. If you are happy with the change I'll give it a test locally and look to merge it all in

Thanks for changing the translation!
We're happy enough with it and you can merge it!

kuragehimekurara1 · 2022-04-10T22:26:44Z

I got it

Add "ja" to resconfig

kuragehimekurara1 · 2022-04-11T05:23:41Z

Updated build.gradle. Is this correct?

Chesire · 2022-04-11T17:43:42Z

Updated build.gradle. Is this correct?

Yup looks good 👍

Some translations were changed and corrected.

Update string to target part of the login_sign_up string.

Chesire · 2022-04-14T19:37:46Z

libraries/core/src/main/res/values-ja/strings.xml

+    <string name="login_forgot_password_url">https://kitsu.io/password-reset</string>
+    <string name="login_sign_up">こちらからKitsuに登録出来ます</string>
+    <!-- This text should be exactly what part of login_sign_up should be a link -->
+    <string name="login_sign_up_link_target">こちらから</string>


I've made a change here to show what I think the string should be. It needs to have a matching section in the login_sign_up part. Its used just to set up some formatting for the string above.

Thanks for changing the translation!

Chesire · 2022-04-14T21:10:56Z

Thanks for this 👍

kuragehimekurara1 added 2 commits April 10, 2022 03:24

Japanese translation completed

057dda3

Japanese translation has been completed.

Japanese translation update

fb27b9a

Added Japanese translation of timeline

kuragehimekurara1 added 3 commits April 11, 2022 00:56

Create strings.xml

6c4a7e2

Japanese translation

d34b044

Please confirm that the Japanese translation has been completed.

fixed translation

aba3662

Corrected the translation of strings.xml

Chesire reviewed Apr 10, 2022

View reviewed changes

Update build.gradle

95f1ffb

Add "ja" to resconfig

kuragehimekurara1 and others added 2 commits April 15, 2022 00:33

Fixed Japanese translation

d640e40

Some translations were changed and corrected.

refactor: update login_sign_up_link_target

2cea34d

Update string to target part of the login_sign_up string.

Chesire reviewed Apr 14, 2022

View reviewed changes

Chesire merged commit aa321cb into Chesire:master Apr 14, 2022

Chesire mentioned this pull request Apr 14, 2022

Japanese translation #741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Japanese translation has been completed. #751

Japanese translation has been completed. #751

kuragehimekurara1 commented Apr 9, 2022

commit-lint bot commented Apr 9, 2022 •

edited

Loading

Chesire commented Apr 9, 2022

kuragehimekurara1 commented Apr 9, 2022

Chesire commented Apr 10, 2022

kuragehimekurara1 commented Apr 10, 2022

Chesire commented Apr 10, 2022

kuragehimekurara1 commented Apr 10, 2022

kuragehimekurara1 commented Apr 10, 2022

codecov bot commented Apr 10, 2022 •

edited

Loading

Chesire left a comment

Chesire Apr 10, 2022

kuragehimekurara1 Apr 10, 2022

Chesire Apr 11, 2022

kuragehimekurara1 Apr 14, 2022

Chesire Apr 14, 2022

kuragehimekurara1 Apr 14, 2022

kuragehimekurara1 commented Apr 10, 2022

kuragehimekurara1 commented Apr 11, 2022

Chesire commented Apr 11, 2022

Chesire Apr 14, 2022

kuragehimekurara1 Apr 14, 2022

Chesire commented Apr 14, 2022

Japanese translation has been completed. #751

Japanese translation has been completed. #751

Conversation

kuragehimekurara1 commented Apr 9, 2022

commit-lint bot commented Apr 9, 2022 • edited Loading

Code Refactoring

Contributors

Chesire commented Apr 9, 2022

kuragehimekurara1 commented Apr 9, 2022

Chesire commented Apr 10, 2022

kuragehimekurara1 commented Apr 10, 2022

Chesire commented Apr 10, 2022

kuragehimekurara1 commented Apr 10, 2022

kuragehimekurara1 commented Apr 10, 2022

codecov bot commented Apr 10, 2022 • edited Loading

Codecov Report

Chesire left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kuragehimekurara1 commented Apr 10, 2022

kuragehimekurara1 commented Apr 11, 2022

Chesire commented Apr 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chesire commented Apr 14, 2022

commit-lint bot commented Apr 9, 2022 •

edited

Loading

codecov bot commented Apr 10, 2022 •

edited

Loading