Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old encryption library #645

Merged
merged 2 commits into from
Sep 18, 2021

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Sep 18, 2021

Remove the old encryption library from the project and makes use of a single LocalAuth instance.
Mostly a tidy up now that the refactor in #638

Remove the old encryption module which is no longer required due to not using the out of date
encryption library.
Since there is now just the one auth instance we can rename it back to just LocalAuth.
@Chesire Chesire self-assigned this Sep 18, 2021
@ChesireBot
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #645 (92e9090) into master (76a4896) will decrease coverage by 0.68%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #645      +/-   ##
============================================
- Coverage     69.79%   69.11%   -0.69%     
+ Complexity      454      440      -14     
============================================
  Files           110      109       -1     
  Lines          1725     1677      -48     
  Branches        145      142       -3     
============================================
- Hits           1204     1159      -45     
+ Misses          477      475       -2     
+ Partials         44       43       -1     
Impacted Files Coverage Δ
...nekome/datasource/auth/local/PreferenceProvider.kt 0.00% <0.00%> (ø)
.../chesire/nekome/datasource/auth/local/LocalAuth.kt 90.00% <90.00%> (ø)
...esire/nekome/datasource/auth/local/AuthProvider.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a4896...92e9090. Read the comment docs.

@Chesire Chesire merged commit 6fadc80 into master Sep 18, 2021
@Chesire Chesire deleted the refactor/remove-old-encryption-library branch September 18, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants