fix: crash in encryption library #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the encryption done by the keystore library, and instead migrate to just store the tokens in shared preferences. They should be safe without being encrypted as they are just some tokens, and require root to access anyway. BREAKING CHANGE: Old shared preference values will be deprecated and no longer be valid
Higher Android SDK versions can use the new androidx crypto library, add using this encrypted preferences for these Android versions and fallback to unencrypted preferences when we are on a lower sdk version.
Change the test file for the AuthProvider to now be for the LocalAuthV1 class
Code Refactoring
Tests
StylesContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Chesire
commented
Sep 10, 2021
libraries/datasource/auth/src/main/java/com/chesire/nekome/datasource/auth/local/LocalAuthV2.kt
Show resolved
Hide resolved
ChesireBot
reviewed
Sep 10, 2021
libraries/datasource/auth/src/main/java/com/chesire/nekome/datasource/auth/local/LocalAuthV2.kt
Show resolved
Hide resolved
ChesireBot
reviewed
Sep 10, 2021
libraries/datasource/auth/src/main/java/com/chesire/nekome/datasource/auth/local/LocalAuthV2.kt
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
ChesireBot
reviewed
Sep 10, 2021
libraries/datasource/auth/src/main/java/com/chesire/nekome/datasource/auth/local/LocalAuthV2.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
============================================
- Coverage 70.22% 69.79% -0.43%
- Complexity 434 454 +20
============================================
Files 106 110 +4
Lines 1639 1725 +86
Branches 139 145 +6
============================================
+ Hits 1151 1204 +53
- Misses 445 477 +32
- Partials 43 44 +1
Continue to review full report at Codecov.
|
Chesire
commented
Sep 10, 2021
libraries/datasource/auth/src/main/java/com/chesire/nekome/datasource/auth/local/LocalAuthV2.kt
Outdated
Show resolved
Hide resolved
Only perform the initialization of the unencrypted preferences if the encrypted preferences is empty. If this is empty then its likely the user has just updated their SDK version and we can then migrate. This stops it initializing two shared prefs every time.
Fix issues with missing kdoc, suppress some unneeded warnings, etc
ChesireBot
reviewed
Sep 11, 2021
| } else { | ||
| "" | ||
| } | ||
| } catch (ex: Exception) { |
There was a problem hiding this comment.
| The caught exception is swallowed. The original exception could be lost. |
Do some refactoring to make it possible to test the class as well.
Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash is sometimes occurring when using the encryption library due to something wrong with the KeyStore in Android.
Done some debugging and it seemed to always be causing an issue while a value was in the preferences, so move away from using the library and instead use the new encrypted shared preferences when possible.
Once this has been merged for a few weeks the encryption library can be tore out completely.