-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reverted field to database and expose telemetrics for reverted events #97
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, I don't think a deal can be reverted. It's only an event that's reverted. While I am not entirely familiar with how this works on the Filecoin side, I would expect a sequence like this:
- Event 1 is emitted, uses e.g.
sector: 123
- Chain re-org happens, deal fields change
- Event 1 is reverted
- Event 2 is emitted. Most of the fields from Event 1 are preserved, but some are changed, e.g.
sector: 125
.
To correctly handle that sequence, we need to remove a deal from active_deals
when an event was reverted, so that it can be added again in the future.
Or maybe we can treat reverted: true
as a soft-delete flag? But then the loops looking up payload CID and uploading deals to spark-api must be updated accordingly.
I think it would be best to not make assumptions and either find documentation of ask FilOz team to better understand what's the correct way to process reverted claim
events.
As this PR only focuses on the observability of when events with a reverted filed set to true occur, does your suggestion influence this PR? |
Co-authored-by: Julian Gruber <[email protected]>
…-station/deal-observer into nhaimerl-reverted-deals
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR proposes the following changes:
reverted
field to the table ofactive_deals
The implementation plan for this PR can be found here.
Closes #22