Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden the initial deal-observer implementation #58

Open
11 of 12 tasks
NikolasHaimerl opened this issue Jan 30, 2025 · 3 comments
Open
11 of 12 tasks

Harden the initial deal-observer implementation #58

NikolasHaimerl opened this issue Jan 30, 2025 · 3 comments
Assignees

Comments

@NikolasHaimerl
Copy link
Contributor

NikolasHaimerl commented Jan 30, 2025

There are a number of issues that were created during the implementation of Spark v1.5. This issues categorizes these issues into those which are critical and non-critical for hardening the implementation, those which are quick and easy fixes and those which are expected to need more time to complete.

Critical + Low Effort

Critical + Moderate Effort

Critical + High Effort


Non-Critical + Low Effort

Non-Critical + Moderate Effort

Non-Critical + High Effort

@juliangruber
Copy link
Member

Great structure in this issue 👏

@bajtos
Copy link
Member

bajtos commented Feb 21, 2025

Let's remove this task from this milestone.

  • We are pretty much done with features that require design/architectural work in spark-deal-observer.
  • Next, we want to add support for Curio. Looking at the tasks in Spark DDO support for Curio, they don't seem to require changes in the way how spark-deal-observer queries the database.
  • Finding a good design for the repository pattern requires non-trivial effort and most likely more than one round of discussion. We need that time elsewhere.

We can take another look at introducing the repository pattern when we work on features that could use a better design for database integration, e.g. when adding a REST API exposing the active_deals table.

@NikolasHaimerl
Copy link
Contributor Author

NikolasHaimerl commented Feb 21, 2025

Let's remove this task from this milestone.

* We are pretty much done with features that require design/architectural work in spark-deal-observer.

* Next, we want to add support for Curio. Looking at the tasks in [Spark DDO support for Curio](https://github.com/CheckerNetwork/roadmap/issues/231), they don't seem to require changes in the way how spark-deal-observer queries the database.

* Finding a good design for the repository pattern requires non-trivial effort and most likely more than one round of discussion. We need that time elsewhere.

We can take another look at introducing the repository pattern when we work on features that could use a better design for database integration, e.g. when adding a REST API exposing the active_deals table.

Should we also remove #51 from this issue? It would fall into the same logic as We are pretty much done with features that require design/architectural work in spark-deal-observer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 in progress
Development

No branches or pull requests

4 participants