refactor: code cleanup after rewards loop move #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep track of last rewards & job-count inside the metrics component, so that we don't have to maintain & share that state between "lib/rewards" and "lib/zinnia". Signed-off-by: Miroslav Bajtoš <[email protected]>
Also remove `lib/obj.js` as it's no longer needed. Signed-off-by: Miroslav Bajtoš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not entirely happy with the implementation details introduced in #462. In particular, I find the
Objreference/pointer-like structure too unusual/non-idiomatic in JavaScript.I am proposing the following two changes:
refactor: allow submission of partial metrics
Keep track of the last rewards & job count inside the metrics component so that we don't have to maintain & share that state between "lib/rewards" and "lib/zinnia".
refactor: update
contractsarray in placeWe used to perform in-place updates before #462, this commit is effectively brining that old design back.
Also, remove
lib/obj.jsas it's no longer needed.