Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rewards update loop out of zinnia loop #462

Merged
merged 3 commits into from
May 14, 2024

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented May 14, 2024

@juliangruber juliangruber requested a review from bajtos May 14, 2024 13:18
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing 😢

@bajtos
Copy link
Member

bajtos commented May 14, 2024

Added two more commits. The first one makes it easier to troubleshoot the problem, the second one fixes the bug.

@bajtos bajtos merged commit bdb853f into main May 14, 2024
18 checks passed
@bajtos bajtos deleted the refactor/update-rewards-loop branch May 14, 2024 14:35
Copy link

sentry-io bot commented May 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ExecaError: Command failed with exit code 1: /usr/src/app/modules/zinnia/zinniad voyager/main.js sendSaturnRequest(voyager) View Issue
  • ‼️ AbortError: This operation was aborted runUpdateSourceFilesLoop(zinnia) View Issue
  • ‼️ ExecaError: Command failed with exit code 1: /usr/src/app/modules/zinnia/zinniad voyager/main.js sendSaturnRequest(voyager) View Issue
  • ‼️ ExecaError: Command failed with exit code 1: '/Applications/Filecoin Station.app/Contents/Resources/core/modu... sendSaturnRequest(voyager) View Issue
  • ‼️ ExecaError: Command failed with exit code 1: "C:\Program Files\Filecoin Station\resources\core\modules\zinnia... sendSaturnRequest(voyager) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants