-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS upload fix #949
IPFS upload fix #949
Conversation
Still janky
Class cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is marketplace always getting deleted :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no idea, i cloned a new repo, still doing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added it back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this change, git checkout main "src/UnitySampleProject/ProjectSettings/EditorBuildSettings.asset"
and push this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for now, but should be converted into a Web3 Service too in the next versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I like when things are working at the first try.
We just need to clarify in the docs that the dev needs to use the API secret key from Storage and not the ID
Metadata.json content:
{"Description":"An NFT description","External_url":"https://google.com.ar","Image":"https://ipfs.chainsafe.io/ipfs/QmbgA3d7vGq4zvfMskDWnXxmBSpezdqu1HHpKVm5ukzXTP","Name":"Name of the NFT","attributes":[{"Display_types":["Stamina"],"Trait_types":["Health"],"Values":["5"]},{"Display_types":["Boost Number"],"Trait_types":["Thunder Power"],"Values":["20"]}]}
* Janky fix * Still janky * Still janky Still janky * Cleanup * Cleanup Cleanup * Abstracting functions * Class cleanup * Class cleanup Class cleanup * marketplace dll * Update .gitignore * Delete Scriptable Objects.meta * Update EditorBuildSettings.asset
IPFS upload fixed
Users can now upload an image or metadata to storage or both at the same time.
Cleaned up and abstracted classes to match our current classes.
Models for metadata match standards but will also work with the SDK, will update with marketplace PR if needed.
To Test:
Load up the sample scene & scroll to ipfs.
Enter your bucket & API key from storage https://app.storage.chainsafe.io/ into the IPFS sample object on the left.
The metadata is taken from the object in the sample scene and images are prompted for upload at runtime.
Test image, metadata & image & metadata functions.
Result:
Metadata json and images should be reachable via the link returned from the call in the console as well as being visible in the storage bucket dashboard.
closes #948