Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dot/telemetry): remove system.network_state #2078

Merged
merged 3 commits into from
Dec 2, 2021
Merged

chore(dot/telemetry): remove system.network_state #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e59afd
chore(dot/telemetry): remove `system.network_state`
kishansagathiya Nov 29, 2021
399b84c
Merge branch 'development' into kishan/telemetry/remove-system-networ…
kishansagathiya Dec 1, 2021
0aad9cf
Merge branch 'development' into kishan/telemetry/remove-system-networ…
kishansagathiya Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions dot/network/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,11 +397,6 @@ main:
if err != nil {
logger.Debugf("problem sending system.interval telemetry message: %s", err)
}

err = telemetry.GetInstance().SendMessage(telemetry.NewNetworkStateTM(s.host.h, s.Peers()))
if err != nil {
logger.Debugf("problem sending system.interval telemetry message: %s", err)
}
}
}
}
Expand Down
53 changes: 0 additions & 53 deletions dot/telemetry/network_state.go
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions dot/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ const (

preparedBlockForProposingMsg = "prepared_block_for_proposing"

systemConnectedMsg = "system.connected"
systemIntervalMsg = "system.interval"
systemNetworkStateMsg = "system.network_state"
systemConnectedMsg = "system.connected"
systemIntervalMsg = "system.interval"

txPoolImportMsg = "txpool.import"
)
Expand Down Expand Up @@ -185,12 +184,6 @@ type Message interface {
messageType() string
}

type peerInfo struct {
Roles byte `json:"roles"`
BestHash string `json:"bestHash"`
BestNumber uint64 `json:"bestNumber"`
}

// NoopHandler struct no op handling (ignoring) telemetry messages
type NoopHandler struct {
}
Expand Down