chore(dot/telemetry): remove system.network_state
#2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `system.network_state` telemetry message since it is not being used by telemetry server
Codecov Report
@@ Coverage Diff @@
## development #2078 +/- ##
===============================================
+ Coverage 60.65% 60.69% +0.04%
===============================================
Files 204 203 -1
Lines 27331 27295 -36
===============================================
- Hits 16577 16568 -9
+ Misses 8848 8825 -23
+ Partials 1906 1902 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kishansagathiya
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
noot,
qdm12 and
timwu20
as code owners
qdm12
approved these changes
Dec 1, 2021
EclesioMeloJunior
approved these changes
Dec 2, 2021
kishansagathiya
deleted the
kishan/telemetry/remove-system-network-state
branch
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
Remove `system.network_state` telemetry message since it is not being used by telemetry server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
system.network_statetelemetry message since it is not beingused by telemetry server
(We are already sending network metrics to prometheus, so did not have to add anything there)
Tests
Issues
Primary Reviewer