3D Tiles - Ternary Functions (fixed) #4761
Conversation
| addStyle('Clamp and Mix', { | ||
| color : "clamp(color(), 0.0, 100.0)", | ||
| pointSize : "mix(0.0, 2.0, 0.5) * 5" | ||
| }); |
There was a problem hiding this comment.
Use some of the point cloud properties in here so that the point cloud is more dynamic looking. Also right now we technically don't support using clamp with anything but numbers (this will change soon).
There was a problem hiding this comment.
It does translate to valid glsl code though by accident.
There was a problem hiding this comment.
So, what kind of properties should I be using? And should I remove clamp then?
There was a problem hiding this comment.
Clamp is fine, I just mean to use the per-point properties temperature or id.
There was a problem hiding this comment.
like clamp(${temperature}, 0.1, 0.2)
There was a problem hiding this comment.
@lilleyse Done!
There was a problem hiding this comment.
Ah my mistake here, the shader doesn't compile because color: clamp(${temperature}, 0.1, 0.2) doesn't result in a color, but "color() * clamp(${temperature}, 0.1, 0.2)" should do the trick.
Can you also include temperature in the pointSize calculation.
There was a problem hiding this comment.
@lilleyse Also done! Also, I figured out that I can't run the Sandcastle app locally because in the Sandcastle folder, index.html refers to a few scripts that simply don't exist for me; it's easy to see using the javascript console in my chrome browser. So hopefully these adjustments work well.
There was a problem hiding this comment.
Ok, I'm not sure why that's happening but the changes do look good.
|
Thanks @Dylan-Brown |
Previously, I had incorrectly merged into my branch from master in #4709, for issue #4694. This PR is even with the 3d-tiles branch, except the changes I had made for the ternary functions, and so the files changed should reflect only the 4 I changed. Implemented in this PR are the mix and clamp functions for the 3d-tiles styling language. @lilleyse