Use new OCI labels instead of label-schema ones #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [convention draft](http://label-schema.org/rc1/) clearly states that `org.label-schema.build-date` should be in [RFC 3339](https://tools.ietf.org/html/rfc3339) format: > This label contains the Date/Time the image was built. The value SHOULD be formatted according to RFC 3339. Addresses CentOS/sig-cloud-instance-images#100 (comment)
|
Can one of the admins verify this patch? |
|
definitely value in keeping both for sometime |
|
@kbsingh good idea. Updating |
zoidyzoidzoid
commented
Oct 4, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the work in #151
Addresses #151 (comment), though they had the smart suggestion of adding both sets of labels for the time being, until the OCI ones mature.
Partially addresses CentOS/sig-cloud-instance-images#100 too