Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative OpenShift login methods #108

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

ifireball
Copy link
Contributor

Add support for alternative ways to login to OpenShift:

  1. Support skipping the loging process and assuming the user logged-in manually via the command line
  2. Support logging in with a token instead of a username and a password

Resolves part #2 and #3 of issue #104

@adl-bot
Copy link

adl-bot commented Nov 5, 2018

Can one of the admins verify this patch?

@ifireball
Copy link
Contributor Author

Not sure why is the bot even asking if the test starts running already...

@arilivigni
Copy link
Member

[test]

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of optionally skipping login and using the token and those changes look good to me, but this PR also includes the changes from PR #107 which I think needs a different approach.

@ifireball
Copy link
Contributor Author

ifireball commented Nov 5, 2018

@dirgim I think I can change the patch order, let me do that and then we can decide what to do about PR #107

Add support for alternative ways to login to OpenShift:
1. Support skipping the loging process and assuming the user logged-in
   manually via the command line
2. Support logging in with a token instead of a username and a password

This partially resolves issue CentOS-PaaS-SIG#104

Signed-off-by: Barak Korren <[email protected]>
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arilivigni arilivigni merged commit a7bd90f into CentOS-PaaS-SIG:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants