-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative OpenShift login methods #108
Conversation
Fix issue CentOS-PaaS-SIG#105 Signed-off-by: Barak Korren <[email protected]>
Can one of the admins verify this patch? |
Not sure why is the bot even asking if the test starts running already... |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of optionally skipping login and using the token and those changes look good to me, but this PR also includes the changes from PR #107 which I think needs a different approach.
Add support for alternative ways to login to OpenShift: 1. Support skipping the loging process and assuming the user logged-in manually via the command line 2. Support logging in with a token instead of a username and a password This partially resolves issue CentOS-PaaS-SIG#104 Signed-off-by: Barak Korren <[email protected]>
b320696
to
8a01327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for alternative ways to login to OpenShift:
Resolves part #2 and #3 of issue #104