Use locally installed oc if possible
#107
Conversation
Fix issue CentOS-PaaS-SIG#105 Signed-off-by: Barak Korren <[email protected]>
|
Can one of the admins verify this patch? |
|
We still want to download the client in the default state. That's why this was put here since people complained that they have to download the client themselves. Did you put a conditional around it? We're not going to remove that logic. |
|
Local |
|
[test] |
|
Hard to read on my phone I'll have to look later. In the meantime we can test it |
|
Looks like I have a bug, will fix |
Determine if the righe version of the `oc` binary is installed in `$PATH` and use it if it does. This resolves issue CentOS-PaaS-SIG#102. Signed-off-by: Barak Korren <[email protected]>
ifireball
force-pushed
the
use-local-cp
branch
from
3968807 to
f65ad95
Compare
| command: "{{ oc_bin }} login {{ cluster_ip|quote }} --username={{ username|quote }} --password={{ password|quote }} --insecure-skip-tls-verify=true" |
There was a problem hiding this comment.
Will this login maintain within the shell if done this way for the next call?
There was a problem hiding this comment.
yes. its seems its stored in a file somewhere, so it does not even matter which binary you've used to login.
Also seems to work across oc versions - but that is probably not guaranteed.
|
+1 to @dirgim that was similar to my comment just override and skip the install of the oc client |
|
@dirgim @arilivigni I would like to try and avoid adding yet another configuration variable given that we already have How about if I check for existence, executability and version of the path This way:
There is one thing Ill need to address which is what happens if the binary is in place but of the wrong version - I think I'll just download to a different location in that case (I wouldn't want to just blindly override it) |
|
@ifireball I don't see the big deal if you have your options defined in a file adding one more does not mean you need it on the command line. I think we are over complicating things here for a simple option override that still give you what you want. I would be a -1 on this change. |
|
@ifireball an even easier solution is to symlink your version into the normal location to minishift and we can put a check to see if the version is there and then not download it. This avoids an extra option and avoids the time to download |
|
@arilivigni just to make sure I fully understand what you're saying - you opposed to any form of automated checking for wither (Fine by me, I just want to understand...) |
|
@ifireball I think it is fine to check if it is downloaded and not download the same version again. In your case a symlink would suffice. This way you download it once for the version that needs to be used. Server and client should match. |
|
There is a PR with a better approach in the works |
Determine if the right version of the
ocbinary is installed in$PATHand use it if it does.