Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-898: Show username of the authenticated user in data portal #153

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented Jun 4, 2024

Ticket(s)

  • DIG-898(Show username of the authenticated user in data portal)

Description

  • This adjusts the profile button at the top right to show the user key of the currently-signed-in user (usually their email address). This requires the corresponding branch from Query here

Screenshots (if appropriate)

Before PR

After PR

image

To do/Tickets to be made before merging branch

  • Requires the Query PR here

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@OrdiNeu OrdiNeu requested a review from CourtneyGosselin June 10, 2024 14:18
@OrdiNeu OrdiNeu marked this pull request as ready for review June 10, 2024 14:19
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pop-ups appear in the wrong location, likely depending on where you click the settings toggle. Additionally, the email/username ([email protected]) is not displayed.
image Furthermore, when logging out, I encountered this error message:
image
Attempting to log out again resulted in the following:
image

I am unable to log out.

Additionally, it may be worth addressing the overflow issue in the settings module:
image

@OrdiNeu
Copy link
Contributor Author

OrdiNeu commented Jun 17, 2024

The pop-ups appear in the wrong location, likely depending on where you click the settings toggle.

Fixed in 28f9926

Additionally, the email/username ([email protected]) is not displayed. image

This can only happen if you have the wrong version of Query checked out -- it should be feature/whoami. Otherwise you'll see a 404 in your Network tab.

Furthermore, when logging out, I encountered this error message: image Attempting to log out again resulted in the following: image

I am unable to log out.

This is not fixable here -- it's related to these changes in Tyk, which were introduced but not caught here

Additionally, it may be worth addressing the overflow issue in the settings module: image

Fixed in f042108

@OrdiNeu OrdiNeu requested a review from CourtneyGosselin June 17, 2024 18:39
Copy link
Member

@CourtneyGosselin CourtneyGosselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants