Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonchau/keycloak #513

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Sonchau/keycloak #513

merged 8 commits into from
Mar 27, 2024

Conversation

SonQBChau
Copy link
Contributor

@SonQBChau SonQBChau commented Mar 27, 2024 •
edited
Loading

What's new

  • Upgrade keycloak from 16 to 24
  • Update Tyk logout with id_token when logout
  • Clean up

How to test

  • Pull this branch and rebuild
  • Run test-integration
  • Login portal and logout, should redirect to the login page

@SonQBChau SonQBChau marked this pull request as ready for review March 27, 2024 18:04
@SonQBChau SonQBChau requested a review from daisieh March 27, 2024 18:05
daisieh
daisieh approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much for cleaning up and refactoring the setup files; this looks much better.

I tested on dev with test-integration and checked the portal for login/logout, and they worked great.

@SonQBChau SonQBChau merged commit f1d603a into develop Mar 27, 2024
2 checks passed
@SonQBChau SonQBChau deleted the sonchau/keycloak branch March 27, 2024 23:01
daisieh pushed a commit that referenced this pull request May 14, 2024
@SonQBChau @daisieh
Sonchau/keycloak (#513)
79e9b14 
* remove old files

* add new files

* Update keycloak_setup.sh

* Update docker-compose.yml

* Update .gitignore

* Update example.env

* clean up old instructions

* update Tyk logout to work with new keycloak
@OrdiNeu OrdiNeu mentioned this pull request Jun 17, 2024
Merged
12 tasks
daisieh pushed a commit that referenced this pull request Jul 16, 2024
@SonQBChau @daisieh
Sonchau/keycloak (#513)
f1f053b 
* remove old files

* add new files

* Update keycloak_setup.sh

* Update docker-compose.yml

* Update .gitignore

* Update example.env

* clean up old instructions

* update Tyk logout to work with new keycloak
daisieh pushed a commit that referenced this pull request Oct 4, 2024
@SonQBChau @daisieh
Sonchau/keycloak (#513)
94157fd 
* remove old files

* add new files

* Update keycloak_setup.sh

* Update docker-compose.yml

* Update .gitignore

* Update example.env

* clean up old instructions

* update Tyk logout to work with new keycloak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daisieh daisieh daisieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SonQBChau @daisieh