test: Use insta for mermaid/dot render tests
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 80.21% 79.77% -0.45%
==========================================
Files 21 21
Lines 5186 5043 -143
Branches 5186 5043 -143
==========================================
- Hits 4160 4023 -137
Misses 949 949
+ Partials 77 71 -6 ☔ View full report in Codecov by Sentry. |
lmondada
approved these changes
Jun 24, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
## 🤖 New release * `portgraph`: 0.12.1 -> 0.12.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.12.2](v0.12.1...v0.12.2) - 2024-07-05 ### Bug Fixes - Intergraph edges in mermaid rendering ([#139](#139)) ### New Features - Add PortOffset::opposite ([#136](#136)) - Efficient LCA algorithm for the hierarchy ([#138](#138)) ### Testing - Use `insta` for mermaid/dot render tests ([#137](#137)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the tests for both to a common module, an uses
rstest::fixturesplusinstasnapshots to test things.Adds a
hierarchy_interregionaltest case that shows the bug from CQCL/hugr#1197.