Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PortOffset::opposite #136

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat: Add PortOffset::opposite #136

merged 2 commits into from
Jun 18, 2024

Conversation

lmondada
Copy link
Contributor

@lmondada lmondada commented Jun 18, 2024

I would find such a function a useful, straight-forward addition to the PortOffset API.

@lmondada lmondada requested a review from aborgna-q June 18, 2024 08:39
@lmondada lmondada force-pushed the feat/add_opposite branch from f7b5628 to 2a90c5f Compare June 18, 2024 08:41
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (ab60561) to head (4175666).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   80.17%   80.21%   +0.03%     
==========================================
  Files          21       21              
  Lines        5176     5186      +10     
  Branches     5176     5186      +10     
==========================================
+ Hits         4150     4160      +10     
  Misses        949      949              
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lmondada lmondada added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 4831264 Jun 18, 2024
11 checks passed
@lmondada lmondada deleted the feat/add_opposite branch June 18, 2024 09:10
@hugrbot hugrbot mentioned this pull request Jun 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 5, 2024
## 🤖 New release
* `portgraph`: 0.12.1 -> 0.12.2

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.12.2](v0.12.1...v0.12.2)
- 2024-07-05

### Bug Fixes
- Intergraph edges in mermaid rendering
([#139](#139))

### New Features
- Add PortOffset::opposite
([#136](#136))
- Efficient LCA algorithm for the hierarchy
([#138](#138))

### Testing
- Use `insta` for mermaid/dot render tests
([#137](#137))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
@hugrbot hugrbot mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants