Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Act clean up part 1 #6680

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Oct 2, 2023

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

Remove usage of act and implement the userEvent.setup method to retrieve the user object that performs the testing actions.

Additional Information

At this point all the warnings in our frontend test logs have been handled. This PR is to clean up some act wraps that are not throwing warnings and to implement the userEvent.setup in the test files.

Testing

All frontend tests should pass.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johanna-skylight johanna-skylight marked this pull request as ready for review October 3, 2023 15:50
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@johanna-skylight johanna-skylight added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@johanna-skylight johanna-skylight added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit ae6da5c Oct 3, 2023
@johanna-skylight johanna-skylight deleted the johanna/6594_act_wrappers_clean_up_part1 branch October 3, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up the act wraps so we don't get warnings [Part1]
5 participants