Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the act wraps so we don't get warnings [Part1] #6594

Closed
johanna-skylight opened this issue Sep 21, 2023 · 0 comments · Fixed by #6680
Closed

Clean up the act wraps so we don't get warnings [Part1] #6594

johanna-skylight opened this issue Sep 21, 2023 · 0 comments · Fixed by #6680
Assignees

Comments

@johanna-skylight
Copy link
Contributor

johanna-skylight commented Sep 21, 2023

Background

After the jest-dom version mismatches got fixed the project is again unhappy with any act wrappings/usage. The frontend test logs are again being polluted with warnings.

Action requested

Clean up the act wraps to get rid of the warnings and implement the new way to use the UserEvent library in below files:

  • MfaGoogleAuthVerify.test.tsx
  • MfaOktaVerify.test.tsx
  • MfaPhone.test.tsx
  • MfaPhoneVerify.test.tsx
  • MfaSelect.test.tsx
  • MfaSms.test.tsx
  • MfaSmsVerify.test.tsx
  • SecurityQuestion.test.tsx
  • ActionsMenu.test.tsx
  • Pagination.test.tsx

Acceptance Criteria

The frontend test logs should not display warnings due to usage of act method.

@johanna-skylight johanna-skylight changed the title Clean up the act wraps so we don't get warnings. Clean up the act wraps so we don't get warnings [Part1] Sep 21, 2023
@johanna-skylight johanna-skylight self-assigned this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants