Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage frontend act warnings #6491

Closed
fzhao99 opened this issue Sep 5, 2023 · 1 comment · Fixed by #6583
Closed

Triage frontend act warnings #6491

fzhao99 opened this issue Sep 5, 2023 · 1 comment · Fixed by #6583
Assignees

Comments

@fzhao99
Copy link
Contributor

fzhao99 commented Sep 5, 2023

Background

As detailed in several previous PR's, our frontend tests sometime get cluttered with act warnings. These are coming from component side effects triggering after a testing block and may contribute to flakiness / indeterminate tests. See the writeup in this PR for more details.

We're getting act warnings in places we shouldn't be though and are currently getting around it by wrapping our tests in act, which isn't recommended. Fixing the issue has been a bit of a headache but might be related to a mismatched subdependency shared by several testing library. Bob has explored this fix initially on a separate branch and found promising results.

Action requested

Triage fixing the frontend act warnings. Push to a separate feature branch any quick straightforward fixes and make tickets for the rest.

Acceptance Criteria

  • Feature branch created with easy fixes
  • tickets created for remainder of work
@mehansen mehansen changed the title [SPIKE] - Determine a way to fix our frontend act warnings Triage frontend act warnings Sep 19, 2023
@johanna-skylight
Copy link
Contributor

Tickets created for follow up effort:
#6593
#6594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants