Johanna/6163 site admin update user access tab #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in_update_user_access_tab Merged with latest main
…in_update_user_access_tab Merged with latest main
…in_update_user_access_tab Merged with latest main code
…in_update_user_access_tab Merged with latest main
…in_update_user_access_tab Merged with latest main
johanna-skylight
temporarily deployed
to
Dev4
GitHub Actions
Inactive
johanna-skylight
temporarily deployed
to
Dev4
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| onChange={onChange} | ||
| ref={ref} | ||
| assistiveHint={describeText(error?.message)} | ||
| disabled={loadingOrgs || disabled} |
Check warning
Code scanning / CodeQL
Useless conditional
|
I've reproduced something similar to what @BobanL noticed with the radio buttons in
|
…in_update_user_access_tab Merged with latest main
johanna-skylight
force-pushed
the
johanna/6163_site_admin_update_user_access_tab
branch
from
808dc90 to
a2d514a
Compare
johanna-skylight
temporarily deployed
to
Dev4
GitHub Actions
Inactive
johanna-skylight
temporarily deployed
to
Dev4
GitHub Actions
Inactive
@mehansen @BobanL I have deployed a change that hopefully fixes the issue completely. Please clear the cache of your browser before reloading the latest code in dev4. LMK how it goes! |
BobanL
previously approved these changes
Sep 21, 2023
…in_update_user_access_tab Integrated cypress fix
fzhao99
previously approved these changes
Sep 21, 2023
emyl3
previously approved these changes
Sep 21, 2023
johanna-skylight
dismissed stale reviews from emyl3, fzhao99, and BobanL
via
929415c
|
Kudos, SonarCloud Quality Gate passed! |
|
I had to fix some merge conflicts after the jes-dom upgrade got to main. I need approvals thanks!!! |
BobanL
approved these changes
Sep 22, 2023
fzhao99
approved these changes
Sep 22, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
johanna-skylight
deleted the
johanna/6163_site_admin_update_user_access_tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
Implement the organization access tab to allow a site admin make updates of organization, role and facility access on any SimpleReport user.
Additional Information
Some refactor on components have been made so they can be reused in the new user form as well as the organization access form.
Testing
Code is available in dev4
Verify that the site admin can make any privilege update to a SimpleReport user.
Screenshots / Demos
Support.admin._.SimpleReport.5.webm