Prepend sample dataset GI PMF with a zero #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsusswein
force-pushed
the
zs-prepend-zero
branch
from
2326d40 to
ccf9182
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
zsusswein
force-pushed
the
zs-prepend-zero
branch
from
ccf9182 to
a0aaf19
Compare
seabbs
approved these changes
Nov 15, 2024
This missing zero was biasing Rt estimates to the dataset because of the right-shifted GI probability mass. Closes #69
zsusswein
force-pushed
the
zs-prepend-zero
branch
from
a0aaf19 to
61a9adb
Compare
zsusswein
added a commit
to CDCgov/cfa-epinow2-pipeline
that referenced
this pull request
Dec 19, 2024
This is analagous to CDCgov/cfa-gam-rt#70
zsusswein
added a commit
to CDCgov/cfa-epinow2-pipeline
that referenced
this pull request
Jan 14, 2025
This is analagous to CDCgov/cfa-gam-rt#70
zsusswein
added a commit
to CDCgov/cfa-epinow2-pipeline
that referenced
this pull request
Jan 14, 2025
This is analagous to CDCgov/cfa-gam-rt#70
zsusswein
added a commit
to CDCgov/cfa-epinow2-pipeline
that referenced
this pull request
Jan 14, 2025
* Add warning and autofix for improper GI PMF With a non-zero first element, contravening assumptions of the renewal equation. * Move tests and package data to 0 first element This is analagous to CDCgov/cfa-gam-rt#70 * Add a test for the new warning And while I'm in here, clean up the flaky test helper which is thrown by the parameters tests. Closes #97 * Bump NEWS * Use new name in NAMESPACE * Update quoting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing zero was biasing Rt estimates to the dataset because
of the right-shifted GI probability mass.
Closes #69