Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wood thinning changes from UM7 repository #433

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

tammasloughran
Copy link
Collaborator

@tammasloughran tammasloughran commented Oct 24, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

While testing on ESM1.5 and ESM1.6 with CABLE3 is still ongoing, we would like to bring the wood thinning changes from the ACCESS_NRI/UM7 repository into the CABLE-LSM repository so that it's ready to go before the code is frozen for spinup.

https://github.com/ACCESS-NRI/UM7/issues/9

Wood thinning branch on UM7

The bug fixes are:

  1. thinning ratio variable should not be initialized to 0
  2. thinned biomass should be added to the wood_flux output variable.
  3. the newlitter_thin routine only aggregated root carbon and not leaf carbon to be redistributed to the litter pools.
  4. The newlitter_thin could possibly edit non-forest tiles, when it shouldn't.

Fixes #432

Type of change

  • Bug fix
  • New or updated documentation

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--433.org.readthedocs.build/en/433/

@ccarouge
Copy link
Member

ccarouge commented Nov 6, 2024

@tammasloughran This hasn't changed in 2 weeks. Is this ready for review or are you working on it?

@tammasloughran
Copy link
Collaborator Author

Yes, I do not have any further changes. I would like someone to review it.

@ccarouge
Copy link
Member

Can you go to the "Reviewers" menu and choose a reviewer? If you want a science review, choose who you think is best. For a tech review, choose the team "CABLE-LSM/tech-reviewers".

@tammasloughran tammasloughran requested review from JhanSrbinovsky, a team and abhaasgoyal and removed request for a team November 12, 2024 00:55
@ccarouge
Copy link
Member

@tammasloughran I'm just piping in to say the interface files for ESM1.6 will go in a coupled/ESM1.6/ directory. Not ESM1.5 as you have now. So before this can only go in once:

  • the directory is there (@bschroeter is creating it right now I believe)
  • this is modified to move/copy the files to ESM1.6 (will need to restore ESM1.5/ directory to its original state).

@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/wood-thinning-in-access/1923/1

@ccarouge
Copy link
Member

ccarouge commented Dec 2, 2024

@tammasloughran the coupled/esm16 directory is now in place. Can you move your changes to that directory? Make sure to leave ESM1.5/ directory in its original state.

@tammasloughran tammasloughran merged commit b82b818 into main Dec 3, 2024
7 checks passed
@tammasloughran tammasloughran deleted the 432-wood-thinning branch December 3, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants