Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating wood thinning forest management bugfixes from UM_v7 into the main CABLE branch for CABLE3 in ESM1.6 #432

Closed
tammasloughran opened this issue Oct 24, 2024 · 3 comments · Fixed by #433
Assignees

Comments

@tammasloughran
Copy link
Collaborator

While testing on ESM1.5 and ESM1.6 with CABLE3 is still ongoing, we would like to bring the wood thinning changes from the ACCESS_NRI/UM7 repository into the CABLE-LSM repository so that it's ready to go before the code is frozen for spinup.

Wood thinning issue on UM7

Wood thinning branch on UM7

I will create a branch for this here also in preparation to merge sometime in the future.

@tammasloughran tammasloughran self-assigned this Oct 24, 2024
@tammasloughran
Copy link
Collaborator Author

Rachel warned me that some files have C preprocessor ifdef statements that may interfere with what is/is not compiled.
src/coupled/ESM1.5/casa_landuse.F90 has these C preprocessor sentinels. I have removed them in the thinning branch here. Hope that's okay.

@tammasloughran
Copy link
Collaborator Author

The bug fixes are:

  1. thinning ratio variable should not be initialized to 0
  2. thinned biomass should be added to the wood_flux output variable.
  3. the newlitter_thin routine only aggregated root carbon and not leaf carbon to be redistributed to the litter pools.
  4. The newlitter_thin could possibly edit non-forest tiles, when it shouldn't.

@access-hive-bot
Copy link

This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/wood-thinning-in-access/1923/1

@github-project-automation github-project-automation bot moved this from In Progress to Done in ACCESS-ESM1.6 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants