Bugfix/handle default fields #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisFederico
requested changes
Dec 6, 2021
Comment on lines
+336
to
+344
| def complete_with_default(self, data: OrderedDict) -> None: | ||
| """Add default data in place when fields are missing""" | ||
| for key in NONE_OPTIONAL_FIELDS: | ||
| if key not in data: | ||
| raise ValueError(f"{key} of the socket is missing") | ||
|
|
||
| for key in DEFAULT_BLOCK_DATA: | ||
| if key not in data: | ||
| data[key] = DEFAULT_BLOCK_DATA[key] |
There was a problem hiding this comment.
Using global constants lead to a triple duplicate of this same code, a good example of why constants should be use with care !
There was a problem hiding this comment.
I still feel like this is a duplicate, am I missing something ?
MathisFederico
requested changes
Dec 9, 2021
Comment on lines
+336
to
+344
| def complete_with_default(self, data: OrderedDict) -> None: | ||
| """Add default data in place when fields are missing""" | ||
| for key in NONE_OPTIONAL_FIELDS: | ||
| if key not in data: | ||
| raise ValueError(f"{key} of the socket is missing") | ||
|
|
||
| for key in DEFAULT_BLOCK_DATA: | ||
| if key not in data: | ||
| data[key] = DEFAULT_BLOCK_DATA[key] |
There was a problem hiding this comment.
I still feel like this is a duplicate, am I missing something ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default fields to edges, sockets, blocks, code blocks and scenes.
Resolves issue #95 for most practical purposes.