Skip to content

Commit

Permalink
Merge branch 'bugfix/handle_default_fields' into Add-ipynb-conversion…
Browse files Browse the repository at this point in the history
…-draft
  • Loading branch information
FabienRoger committed Dec 6, 2021
2 parents e6032f2 + f223d27 commit e233ae3
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion opencodeblocks/blocks/block.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,6 @@ def complete_with_default(self, data: OrderedDict) -> None:
if key not in data:
raise ValueError(f"{key} of the socket is missing")

for key in DEFAULT_BLOCK_DATA.keys():
for key in DEFAULT_BLOCK_DATA:
if key not in data:
data[key] = DEFAULT_BLOCK_DATA[key]
4 changes: 2 additions & 2 deletions opencodeblocks/blocks/codeblock.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ def complete_with_default(self, data: OrderedDict) -> None:
if key not in data:
raise ValueError(f"{key} of the socket is missing")

for key in DEFAULT_CODE_BLOCK_DATA.keys():
for key in DEFAULT_CODE_BLOCK_DATA:
if key not in data:
data[key] = DEFAULT_CODE_BLOCK_DATA[key]

super().complete_with_default(data)
2 changes: 1 addition & 1 deletion opencodeblocks/graphics/edge.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,6 @@ def complete_with_default(self, data: OrderedDict) -> None:
if key not in data:
raise ValueError(f"{key} of the socket is missing")

for key in DEFAULT_EDGE_DATA.keys():
for key in DEFAULT_EDGE_DATA:
if key not in data:
data[key] = DEFAULT_EDGE_DATA[key]
3 changes: 1 addition & 2 deletions opencodeblocks/graphics/socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ def complete_with_default(self, data: OrderedDict) -> None:
if key not in data:
raise ValueError(f"{key} of the socket is missing")

for key in DEFAULT_SOCKET_DATA.keys():
for key in DEFAULT_SOCKET_DATA:
if key not in data:
data[key] = DEFAULT_SOCKET_DATA[key]

0 comments on commit e233ae3

Please sign in to comment.