Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up bugs from call refactor #78

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Clean up bugs from call refactor #78

merged 1 commit into from
Oct 30, 2020

Conversation

danielolsen
Copy link
Contributor

Purpose

Clean up lingering issues from #74. See comments in Breakthrough-Energy/PowerSimData#324 for more context.

Time to review

5 minutes.

@BainanXia
Copy link
Collaborator

Should I be able to test it just by running a test scenario on my end? Is this branch checked out on the server?

@danielolsen
Copy link
Contributor Author

Should I be able to test it just by running a test scenario on my end? Is this branch checked out on the server?

The branch is checked out on the server right now.

@BainanXia
Copy link
Collaborator

For some reason, my test scenario (1546) is created and executed successfully but not auto extracted.

@danielolsen
Copy link
Contributor Author

Did you also have the anna/reisejl branch of PowerSimData checked out? That's where the flag to extract gets set (unless we specify not to).

@BainanXia
Copy link
Collaborator

@danielolsen I should have waited for a few seconds...It works!

Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants